mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-23 08:46:40 +00:00
Code Issues 1 Projects Releases Wiki Activity

Update the buffering state before stalling for more data

Browse source 
In some cases the wait for more data was happening without updating
the buffering state, meaning the API user would not be able to notice
it should pause the pipeline and update UI to indicate that is the
case, the video would likely stutter instead.

https://bugzilla.gnome.org/show_bug.cgi?id=707648
This commit is contained in:
Gustavo Noronha Silva 2013-09-06 15:09:46 -03:00 committed by Sebastian Dröge
parent 3dc8ee97e5
commit 4cb596ddd6
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
plugins/elements/gstqueue2.c
View file

@ -255,6 +255,7 @@ static gboolean gst_queue2_is_empty (GstQueue2 * queue);
static gboolean gst_queue2_is_filled (GstQueue2 * queue);
static void update_cur_level (GstQueue2 * queue, GstQueue2Range * range);
static void update_in_rates (GstQueue2 * queue);
typedef enum
{
@ -875,6 +876,10 @@ update_buffering (GstQueue2 * queue)
gint percent;
gboolean post = FALSE;
/* Ensure the variables used to calculate buffering state are up-to-date. */
update_cur_level (queue, queue->current);
update_in_rates (queue);
if (!get_buffering_percent (queue, NULL, &percent))
return;
@ -1285,6 +1290,10 @@ gst_queue2_create_read (GstQueue2 * queue, guint64 offset, guint length,
update_cur_pos (queue, queue->current, rpos);
GST_QUEUE2_SIGNAL_DEL (queue);
}
if (queue->use_buffering)
update_buffering (queue);
GST_DEBUG_OBJECT (queue, "waiting for add");
GST_QUEUE2_WAIT_ADD_CHECK (queue, queue->srcresult, out_flushing);
continue;