gst_pad_check_reconfigure: only remove flag if set.

the code ifed a debug statement, that can't be right. anyway, the way it is,
we don't really need that branch, as we set the flag to unset only if set
(and that can't fail) hence the end result is always to unset the flag.

Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>

Fixes https://bugzilla.gnome.org/show_bug.cgi?id=691985
This commit is contained in:
Niv Sardi 2013-01-17 21:35:48 -03:00 committed by Wim Taymans
parent 4adee0dee2
commit 4b3aee5698

View file

@ -1407,9 +1407,10 @@ gst_pad_check_reconfigure (GstPad * pad)
GST_OBJECT_LOCK (pad);
reconfigure = GST_PAD_NEEDS_RECONFIGURE (pad);
if (reconfigure)
if (reconfigure) {
GST_DEBUG_OBJECT (pad, "remove RECONFIGURE flag");
GST_OBJECT_FLAG_UNSET (pad, GST_PAD_FLAG_NEED_RECONFIGURE);
GST_OBJECT_FLAG_UNSET (pad, GST_PAD_FLAG_NEED_RECONFIGURE);
}
GST_OBJECT_UNLOCK (pad);
return reconfigure;