mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-07 16:08:51 +00:00
Code Issues 1 Projects Releases Wiki Activity

rtpvp8pay: allocate bitreader on the stack

Browse source
This commit is contained in:
Tim-Philipp Müller 2014-06-18 13:44:31 +01:00
parent 725b8f272b
commit 4b1f771e4d
1 changed files with 10 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
gst/rtp/gstrtpvp8pay.c
View file

@ -174,10 +174,10 @@ static gboolean
gst_rtp_vp8_pay_parse_frame (GstRtpVP8Pay * self, GstBuffer * buffer, gst_rtp_vp8_pay_parse_frame (GstRtpVP8Pay * self, GstBuffer * buffer,
gsize buffer_size) gsize buffer_size)
{ {
GstBitReader *reader = NULL; GstMapInfo map = GST_MAP_INFO_INIT;
GstBitReader reader;
guint8 *data; guint8 *data;
gsize size; gsize size;
GstMapInfo map;
int i; int i;
gboolean keyframe; gboolean keyframe;
guint32 partition0_size; guint32 partition0_size;
@ -196,7 +196,8 @@ gst_rtp_vp8_pay_parse_frame (GstRtpVP8Pay * self, GstBuffer * buffer,
data = map.data; data = map.data;
size = map.size; size = map.size;
reader = gst_bit_reader_new (data, size);
gst_bit_reader_init (&reader, data, size);
self->is_keyframe = keyframe = ((data[0] & 0x1) == 0); self->is_keyframe = keyframe = ((data[0] & 0x1) == 0);
version = (data[0] >> 1) & 0x7; version = (data[0] >> 1) & 0x7;
@ -213,22 +214,22 @@ gst_rtp_vp8_pay_parse_frame (GstRtpVP8Pay * self, GstBuffer * buffer,
offset = keyframe ? 10 : 3; offset = keyframe ? 10 : 3;
partition0_size += offset; partition0_size += offset;
if (!gst_bit_reader_skip (reader, 24)) if (!gst_bit_reader_skip (&reader, 24))
goto error; goto error;
if (keyframe) { if (keyframe) {
/* check start tag: 0x9d 0x01 0x2a */ /* check start tag: 0x9d 0x01 0x2a */
if (!gst_bit_reader_get_bits_uint8 (reader, &tmp8, 8) || tmp8 != 0x9d) if (!gst_bit_reader_get_bits_uint8 (&reader, &tmp8, 8) || tmp8 != 0x9d)
goto error; goto error;
if (!gst_bit_reader_get_bits_uint8 (reader, &tmp8, 8) || tmp8 != 0x01) if (!gst_bit_reader_get_bits_uint8 (&reader, &tmp8, 8) || tmp8 != 0x01)
goto error; goto error;
if (!gst_bit_reader_get_bits_uint8 (reader, &tmp8, 8) || tmp8 != 0x2a) if (!gst_bit_reader_get_bits_uint8 (&reader, &tmp8, 8) || tmp8 != 0x2a)
goto error; goto error;
/* Skip horizontal size code (16 bits) vertical size code (16 bits) */ /* Skip horizontal size code (16 bits) vertical size code (16 bits) */
if (!gst_bit_reader_skip (reader, 32)) if (!gst_bit_reader_skip (&reader, 32))
goto error; goto error;
} }
@ -333,14 +334,12 @@ gst_rtp_vp8_pay_parse_frame (GstRtpVP8Pay * self, GstBuffer * buffer,
self->partition_offset[i + 1] = size; self->partition_offset[i + 1] = size;
gst_bit_reader_free (reader);
gst_buffer_unmap (buffer, &map); gst_buffer_unmap (buffer, &map);
return TRUE; return TRUE;
error: error:
GST_DEBUG ("Failed to parse frame"); GST_DEBUG ("Failed to parse frame");
if (reader) { if (map.memory != NULL) {
gst_bit_reader_free (reader);
gst_buffer_unmap (buffer, &map); gst_buffer_unmap (buffer, &map);
} }
return FALSE; return FALSE;