mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-11 09:55:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

decodebin2: Only prevent to autoplug the same parser multiple times for the same chain

Browse source 
Parsers are the only element class that are not changing the data and
could lead to an infinite loop. Other element classes like demuxers,
e.g. id3demux, can be used multiple times in a row and sometimes are.
This commit is contained in:
Sebastian Dröge 2011-02-27 09:32:55 +01:00
parent c7f5290247
commit 4ac6f5ff83
1 changed files with 26 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
gst/playback/gstdecodebin2.c
View file

@ -1667,8 +1667,6 @@ connect_pad (GstDecodeBin * dbin, GstElement * src, GstDecodePad * dpad,
GstElement *element;
GstPad *sinkpad;
gboolean subtitle;
gboolean skip = FALSE;
GList *l;
/* Set dpad target to pad again, it might've been unset
* below but we came back here because something failed
@ -1680,12 +1678,19 @@ connect_pad (GstDecodeBin * dbin, GstElement * src, GstDecodePad * dpad,
/* Remove selected factory from the list. */
g_value_array_remove (factories, 0);
/* First check if this is a factory for which we have already
* created an element in this chain. If we have, we skip this
* factory because it will lead to an infinite loop. Examples
* for this are parsers that accept their own src caps on the
* sinkpad again.
/* If the factory is for a parser we first check if the factory
* was already used for the current chain. If it was used already
* we would otherwise create an infinite loop here because the
* parser apparently accepts its own output as input.
* This is only done for parsers because it's perfectly valid
* to have other element classes after each other because a
* parser is the only one that does not change the data. A
* valid example for this would be multiple id3demux in a row.
*/
if (strstr (gst_element_factory_get_klass (factory), "Parser")) {
gboolean skip = FALSE;
GList *l;
CHAIN_MUTEX_LOCK (chain);
for (l = chain->elements; l; l = l->next) {
GstElement *otherelement = GST_ELEMENT_CAST (l->data);
@ -1702,6 +1707,7 @@ connect_pad (GstDecodeBin * dbin, GstElement * src, GstDecodePad * dpad,
gst_plugin_feature_get_name (GST_PLUGIN_FEATURE_CAST (factory)));
continue;
}
}
/* emit autoplug-select to see what we should do with it. */
g_signal_emit (G_OBJECT (dbin),