mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-10 17:35:59 +00:00
Code Issues 1 Projects Releases Wiki Activity

isomp4: Don't spam debug log with knonw/padding atoms

Browse source 
Only output WARNING messages for atoms we don't know how to handle
instead of for padding/known atoms we don't need to do any processing
on

https://bugzilla.gnome.org/show_bug.cgi?id=777095
This commit is contained in:
Edward Hervey 2017-01-10 16:01:35 +01:00 committed by Edward Hervey
parent d7b2820b73
commit 4a279f4499
2 changed files with 18 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
gst/isomp4/fourcc.h
View file

@ -220,6 +220,7 @@ G_BEGIN_DECLS
#define FOURCC_stss GST_MAKE_FOURCC('s','t','s','s')
#define FOURCC_stsz GST_MAKE_FOURCC('s','t','s','z')
#define FOURCC_stts GST_MAKE_FOURCC('s','t','t','s')
#define FOURCC_styp GST_MAKE_FOURCC('s','t','y','p')
#define FOURCC_subp GST_MAKE_FOURCC('s','u','b','p')
#define FOURCC_subt GST_MAKE_FOURCC('s','u','b','t')
#define FOURCC_text GST_MAKE_FOURCC('t','e','x','t')

21
gst/isomp4/qtdemux.c
View file

@ -6550,10 +6550,23 @@ gst_qtdemux_process_adapter (GstQTDemux * demux, gboolean force)
GST_DEBUG_OBJECT (demux, "Parsing [sidx]");
qtdemux_parse_sidx (demux, data, demux->neededbytes);
} else {
GST_WARNING_OBJECT (demux,
"Unknown fourcc while parsing header : %" GST_FOURCC_FORMAT,
GST_FOURCC_ARGS (fourcc));
/* Let's jump that one and go back to initial state */
switch (fourcc) {
case FOURCC_styp:
/* [styp] is like a [ftyp], but in fragment header. We ignore it for now
* FALLTHROUGH */
case FOURCC_free:
/* [free] is a padding atom */
GST_DEBUG_OBJECT (demux,
"Skipping fourcc while parsing header : %" GST_FOURCC_FORMAT,
GST_FOURCC_ARGS (fourcc));
break;
default:
GST_WARNING_OBJECT (demux,
"Unknown fourcc while parsing header : %" GST_FOURCC_FORMAT,
GST_FOURCC_ARGS (fourcc));
/* Let's jump that one and go back to initial state */
break;
}
}
gst_adapter_unmap (demux->adapter);
data = NULL;