mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-06 10:42:22 +00:00
Code Issues 1 Projects Releases Wiki Activity

playbin2: If setting the state of the suburidecodebin fails just warn, don't error out

Browse source
This commit is contained in:
Sebastian Dröge 2009-10-24 13:07:45 +02:00
parent cd5475aa6f
commit 497d0a4793
1 changed files with 15 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
gst/playback/gstplaybin2.c
View file

@ -2711,8 +2711,21 @@ activate_group (GstPlayBin * playbin, GstSourceGroup * group, GstState target)
if (suburidecodebin) {
if (gst_element_set_state (suburidecodebin,
target) == GST_STATE_CHANGE_FAILURE)
goto suburidecodebin_failure;
target) == GST_STATE_CHANGE_FAILURE) {
GST_DEBUG_OBJECT (playbin,
"failed state change of subtitle uridecodebin");
GST_SOURCE_GROUP_LOCK (group);
REMOVE_SIGNAL (group->suburidecodebin, group->sub_pad_added_id);
REMOVE_SIGNAL (group->suburidecodebin, group->sub_pad_removed_id);
REMOVE_SIGNAL (group->suburidecodebin, group->sub_no_more_pads_id);
/* Might already be removed because of an error message */
if (GST_OBJECT_PARENT (suburidecodebin) == GST_OBJECT_CAST (playbin))
gst_bin_remove (GST_BIN_CAST (playbin), suburidecodebin);
group->pending = 1;
gst_element_set_state (suburidecodebin, GST_STATE_READY);
GST_SOURCE_GROUP_UNLOCK (group);
}
}
if (gst_element_set_state (uridecodebin, target) == GST_STATE_CHANGE_FAILURE)
goto uridecodebin_failure;
@ -2731,11 +2744,6 @@ no_decodebin:
GST_SOURCE_GROUP_UNLOCK (group);
return FALSE;
}
suburidecodebin_failure:
{
GST_DEBUG_OBJECT (playbin, "failed state change of subtitle uridecodebin");
return FALSE;
}
uridecodebin_failure:
{
GST_DEBUG_OBJECT (playbin, "failed state change of uridecodebin");