mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-07-31 10:45:08 +00:00
Code Issues 1 Projects Releases Wiki Activity

Revert "qtdemux: Always snap to the start of the keyframe"

Browse source 
This reverts commit 107902ec51.

This commit intended to ensure that keyframe seeks land at the
start timestamp of a keyframe, rather than in the middle of one,
but they cause trouble on files with sparse streams, or with
JPEG 'cover art' tracks that have only one or a few JPEG samples
with very long durations.

That's still desirable for doing seamless cutting of videos,
but needs a rethink for implementation.

https://bugzilla.gnome.org/show_bug.cgi?id=778690
This commit is contained in:
Jan Schmidt 2017-02-17 13:07:05 +11:00
parent c32bf052a0
commit 488e8edba4
1 changed files with 26 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

48
gst/isomp4/qtdemux.c
View file

@ -1296,7 +1296,7 @@ gst_qtdemux_adjust_seek (GstQTDemux * qtdemux, gint64 desired_time,
* and move back to the previous keyframe. */ * and move back to the previous keyframe. */
for (n = 0; n < qtdemux->n_streams; n++) { for (n = 0; n < qtdemux->n_streams; n++) {
QtDemuxStream *str; QtDemuxStream *str;
guint32 index; guint32 index, kindex;
guint32 seg_idx; guint32 seg_idx;
GstClockTime media_start; GstClockTime media_start;
GstClockTime media_time; GstClockTime media_time;
@ -1350,33 +1350,37 @@ gst_qtdemux_adjust_seek (GstQTDemux * qtdemux, gint64 desired_time,
if (!empty_segment) { if (!empty_segment) {
/* find previous keyframe */ /* find previous keyframe */
index = gst_qtdemux_find_keyframe (qtdemux, str, index, next); kindex = gst_qtdemux_find_keyframe (qtdemux, str, index, next);
/* we will settle for one before if none found after */ /* we will settle for one before if none found after */
if (next && index == -1) if (next && kindex == -1)
index = gst_qtdemux_find_keyframe (qtdemux, str, index, FALSE); kindex = gst_qtdemux_find_keyframe (qtdemux, str, index, FALSE);
/* Snap to the start ts of the keyframe we found */ /* if the keyframe is at a different position, we need to update the
* requested seek time */
if (index != kindex) {
index = kindex;
/* get timestamp of keyframe */ /* get timestamp of keyframe */
media_time = QTSAMPLE_PTS_NO_CSLG (str, &str->samples[index]); media_time = QTSAMPLE_PTS_NO_CSLG (str, &str->samples[kindex]);
GST_DEBUG_OBJECT (qtdemux, GST_DEBUG_OBJECT (qtdemux,
"keyframe at %u with time %" GST_TIME_FORMAT " at offset %" "keyframe at %u with time %" GST_TIME_FORMAT " at offset %"
G_GUINT64_FORMAT, index, GST_TIME_ARGS (media_time), G_GUINT64_FORMAT, kindex, GST_TIME_ARGS (media_time),
str->samples[index].offset); str->samples[kindex].offset);
/* keyframes in the segment get a chance to change the /* keyframes in the segment get a chance to change the
* desired_offset. keyframes out of the segment are * desired_offset. keyframes out of the segment are
* ignored. */ * ignored. */
if (media_time >= seg->media_start) { if (media_time >= seg->media_start) {
GstClockTime seg_time; GstClockTime seg_time;
/* this keyframe is inside the segment, convert back to /* this keyframe is inside the segment, convert back to
* segment time */ * segment time */
seg_time = (media_time - seg->media_start) + seg->time; seg_time = (media_time - seg->media_start) + seg->time;
if ((!next && (seg_time < min_offset)) || if ((!next && (seg_time < min_offset)) ||
(next && (seg_time > min_offset))) (next && (seg_time > min_offset)))
min_offset = seg_time; min_offset = seg_time;
}
} }
} }