mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-30 12:10:37 +00:00
Code Issues 1 Projects Releases Wiki Activity

baseparse: prevent arithmetic overflows in pull mode buffer cache handling

Browse source
This commit is contained in:
Mark Nauwelaerts 2010-06-15 15:33:37 +02:00
parent 07561dbfd1
commit 484af544bf
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gst/audioparsers/gstbaseparse.c
View file

@ -1341,8 +1341,8 @@ gst_base_parse_pull_range (GstBaseParse * parse, guint size,
/* Caching here actually makes much less difference than one would expect. /* Caching here actually makes much less difference than one would expect.
* We do it mainly to avoid pulling buffers of 1 byte all the time */ * We do it mainly to avoid pulling buffers of 1 byte all the time */
if (parse->priv->cache) { if (parse->priv->cache) {
guint64 cache_offset = GST_BUFFER_OFFSET (parse->priv->cache); gint64 cache_offset = GST_BUFFER_OFFSET (parse->priv->cache);
guint cache_size = GST_BUFFER_SIZE (parse->priv->cache); gint cache_size = GST_BUFFER_SIZE (parse->priv->cache);
if (cache_offset <= parse->priv->offset && if (cache_offset <= parse->priv->offset &&
(parse->priv->offset + size) <= (cache_offset + cache_size)) { (parse->priv->offset + size) <= (cache_offset + cache_size)) {