mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-22 05:56:31 +00:00
Code Issues 1 Projects Releases Wiki Activity

video: convertframe: Shut down pipeline asynchronously via the thread pool

Browse source 
If we use the main loop it might happen that the caller (e.g. our unit
test) already shut down the loop once the result was received and in
that case the pipeline would never ever be shut down (and our unit test
would hang).
This commit is contained in:
Sebastian Dröge 2018-11-30 12:40:19 +02:00
parent 70d8c174ac
commit 48460f5ace
1 changed files with 9 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
gst-libs/gst/video/convertframe.c
View file

@ -489,11 +489,10 @@ convert_frame_dispatch_callback (GstVideoConvertSampleContext * ctx)
return FALSE;
}
static gboolean
convert_frame_stop_pipeline (GstElement * element)
static void
convert_frame_stop_pipeline (GstElement * element, gpointer user_data)
{
gst_element_set_state (element, GST_STATE_NULL);
return FALSE;
}
static void
@ -525,14 +524,14 @@ convert_frame_finish (GstVideoConvertSampleContext * context,
* state to NULL and get rid of its last reference, which in turn
* will get rid of all remaining references to our context and free
* it too. We can't do this directly here as we might be called from
* a streaming thread. */
* a streaming thread.
*
* We don't use the main loop here because the user might shut down it
* immediately after getting the result of the conversion above.
*/
if (context->pipeline) {
source = g_timeout_source_new (0);
g_source_set_callback (source,
(GSourceFunc) convert_frame_stop_pipeline,
context->pipeline, (GDestroyNotify) gst_object_unref);
g_source_attach (source, context->context);
g_source_unref (source);
gst_element_call_async (context->pipeline, convert_frame_stop_pipeline,
NULL, NULL);
context->pipeline = NULL;
}
}