mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-05 18:22:23 +00:00
Code Issues 1 Projects Releases Wiki Activity

webrtcbin: Don't consider transceivers without mid as inactive during ICE gathering state updates

Browse source 
We don't have any mid before parsing the SDP, which happens after we
handled the SDP answer and that usually happens long after ICE candidate
gathering is finished.

Without this all transceivers are considered inactive and as such ICE
gathering is for active transceiver was considered complete from the
very beginning.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/1126
This commit is contained in:
Sebastian Dröge 2020-01-09 12:32:24 +02:00 committed by GStreamer Merge Bot
parent de0f803d56
commit 47ce34d32c
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
ext/webrtc/gstwebrtcbin.c
View file

@ -907,9 +907,10 @@ _collate_ice_gathering_states (GstWebRTCBin * webrtc)
continue;
}
/* We only have a mid in the transceiver after we got the SDP answer,
* which is usually long after gathering has finished */
if (!rtp_trans->mid) {
GST_TRACE_OBJECT (webrtc, "transceiver %p has no mid", rtp_trans);
continue;
}
g_object_get (stream, "rtcp-mux", &rtcp_mux, NULL);