mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-31 19:42:26 +00:00
Code Issues 1 Projects Releases Wiki Activity

lfocontrolsource: fix clang compiler warning

Browse source 
Cast enum to int before checking for negative values, which are
impossible according to the enum list.

gstlfocontrolsource.c:652:45: error: comparison of unsigned enum expression < 0
      is always false [-Werror,-Wtautological-compare]
  if (waveform >= num_waveforms || waveform < 0) {
                                   ~~~~~~~~ ^ ~

https://bugzilla.gnome.org/show_bug.cgi?id=653137
This commit is contained in:
Tim-Philipp Müller 2011-09-13 23:04:09 +01:00
parent 1051eddd4c
commit 46e401b6d9
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
libs/gst/controller/gstlfocontrolsource.c
View file

@ -566,7 +566,7 @@ static GstWaveformImplementation *waveforms[] = {
&waveform_triangle &waveform_triangle
}; };
static guint num_waveforms = G_N_ELEMENTS (waveforms); static const guint num_waveforms = G_N_ELEMENTS (waveforms);
enum enum
{ {
@ -649,7 +649,7 @@ gst_lfo_control_source_set_waveform (GstLFOControlSource * self,
GstControlSource *csource = GST_CONTROL_SOURCE (self); GstControlSource *csource = GST_CONTROL_SOURCE (self);
gboolean ret = TRUE; gboolean ret = TRUE;
if (waveform >= num_waveforms || waveform < 0) { if (waveform >= num_waveforms || (int) waveform < 0) {
GST_WARNING ("waveform %d invalid or not implemented yet", waveform); GST_WARNING ("waveform %d invalid or not implemented yet", waveform);
return FALSE; return FALSE;
} }