mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-26 03:31:05 +00:00
Code Issues 1 Projects Releases Wiki Activity

codecparser: AV1: fix reference frame ordering

Browse source 
In AV1 specifications earliest_order_hint is initialized at
beginning of the process and not before each frame ordering.

FFMPEG parser does the same.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1011>
This commit is contained in:
Benjamin Gaignard 2022-12-05 14:21:42 +01:00 committed by GStreamer Marge Bot
parent 3f24a38c8e
commit 465d146864
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
subprojects/gst-plugins-bad/gst-libs/gst/codecparsers/gstav1parser.c
View file

@ -3393,6 +3393,7 @@ gst_av1_set_frame_refs (GstAV1Parser * parser,
frame_header->order_hint);
last_order_hint = shifted_order_hints[frame_header->last_frame_idx];
earliest_order_hint = shifted_order_hints[frame_header->gold_frame_idx];
/* === Backward Reference Frames === */
/* The ALTREF_FRAME reference is set to be a backward
@ -3415,7 +3416,6 @@ gst_av1_set_frame_refs (GstAV1Parser * parser,
/* The BWDREF_FRAME reference is set to be a backward reference
to the closest frame. */
ref = -1;
earliest_order_hint = last_order_hint;
for (i = 0; i < GST_AV1_NUM_REF_FRAMES; i++) {
hint = shifted_order_hints[i];
if (!used_frame[i] && hint >= cur_frame_hint
@ -3433,7 +3433,6 @@ gst_av1_set_frame_refs (GstAV1Parser * parser,
/* The ALTREF2_FRAME reference is set to the next closest
backward reference. */
ref = -1;
earliest_order_hint = last_order_hint;
for (i = 0; i < GST_AV1_NUM_REF_FRAMES; i++) {
hint = shifted_order_hints[i];
if (!used_frame[i] && hint >= cur_frame_hint
@ -3452,7 +3451,6 @@ gst_av1_set_frame_refs (GstAV1Parser * parser,
/* The remaining references are set to be forward references
in anti-chronological order. */
last_order_hint = 0;
for (i = 0; i < GST_AV1_REFS_PER_FRAME - 2; i++) {
GstAV1ReferenceFrame ref_frame = ref_frame_list[i];
if (frame_header->ref_frame_idx[ref_frame - GST_AV1_REF_LAST_FRAME] < 0) {
@ -3476,7 +3474,6 @@ gst_av1_set_frame_refs (GstAV1Parser * parser,
/* Finally, any remaining references are set to the reference frame
with smallest output order. */
ref = -1;
earliest_order_hint = cur_frame_hint * 2;
for (i = 0; i < GST_AV1_NUM_REF_FRAMES; i++) {
hint = shifted_order_hints[i];
if (ref < 0 || hint < earliest_order_hint) {