mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-23 09:04:15 +00:00
Code Issues 1 Projects Releases Wiki Activity

glviewconvert: Fix texture target fixation

Browse source 
Don't set the chosen texture-target into the wrong structure.
The input caps may not be writable, and in any case - the
intention was to configure the othercaps. Also, remove an
extra unref - the othercaps ref is consumed by
gst_caps_make_writable already.
This commit is contained in:
Jan Schmidt 2016-08-25 15:26:49 +10:00
parent 4f6ae1f48c
commit 45df74868c
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gst-libs/gst/gl/gstglviewconvert.c
View file

@ -1208,7 +1208,7 @@ _fixate_texture_target (GstGLViewConvert * viewconvert,
g_value_set_static_string (&item, GST_GL_TEXTURE_TARGET_EXTERNAL_OES_STR); g_value_set_static_string (&item, GST_GL_TEXTURE_TARGET_EXTERNAL_OES_STR);
} }
gst_structure_set_value (s, "texture-target", &item); gst_structure_set_value (s_other, "texture-target", &item);
g_value_unset (&item); g_value_unset (&item);
@ -1286,9 +1286,7 @@ gst_gl_view_convert_fixate_caps (GstGLViewConvert * viewconvert,
} }
} }
tmp = _fixate_texture_target (viewconvert, direction, caps, othercaps); othercaps = _fixate_texture_target (viewconvert, direction, caps, othercaps);
gst_caps_unref (othercaps);
othercaps = tmp;
done: done:
GST_DEBUG_OBJECT (viewconvert, "dir %s fixated to %" GST_PTR_FORMAT GST_DEBUG_OBJECT (viewconvert, "dir %s fixated to %" GST_PTR_FORMAT