mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-26 19:51:11 +00:00
Code Issues 1 Projects Releases Wiki Activity

curlbasesink: error codes in transfer error details

Browse source 
There is currently no easy way for an application to distinguish between
different resource write errors being set in the curlbasesink.
Add curl status codes as error details on transfer failure.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4062>
This commit is contained in:
Erik Fröbrant 2023-02-23 14:44:34 +00:00 committed by GStreamer Marge Bot
parent 8f094a1cc8
commit 456bbad2dd
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
subprojects/gst-plugins-bad/ext/curl/gstcurlbasesink.c
View file

@ -1032,8 +1032,10 @@ handle_transfer (GstCurlBaseSink * sink)
} }
if (m_code != CURLM_OK) { if (m_code != CURLM_OK) {
sink->error = g_strdup_printf ("failed to write data: %s", GST_ELEMENT_ERROR_WITH_DETAILS (sink, RESOURCE, WRITE,
curl_multi_strerror (m_code)); ("Failed to write data"), ("Curl multi error: %s",
curl_multi_strerror (m_code)), ("curl-multi-status-code",
G_TYPE_INT, m_code, NULL));
retval = GST_FLOW_ERROR; retval = GST_FLOW_ERROR;
goto fail; goto fail;
} }
@ -1041,8 +1043,10 @@ handle_transfer (GstCurlBaseSink * sink)
/* problems still might have occurred on individual transfers even when /* problems still might have occurred on individual transfers even when
* curl_multi_perform returns CURLM_OK */ * curl_multi_perform returns CURLM_OK */
if ((e_code = gst_curl_base_sink_transfer_check (sink)) != CURLE_OK) { if ((e_code = gst_curl_base_sink_transfer_check (sink)) != CURLE_OK) {
sink->error = g_strdup_printf ("failed to transfer data: %s", GST_ELEMENT_ERROR_WITH_DETAILS (sink, RESOURCE, WRITE,
curl_easy_strerror (e_code)); ("Failed to transfer data"), ("Curl easy error: %s",
curl_easy_strerror (e_code)), ("curl-status-code", G_TYPE_INT,
e_code, NULL));
retval = GST_FLOW_ERROR; retval = GST_FLOW_ERROR;
goto fail; goto fail;
} }