mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-27 20:21:24 +00:00
Code Issues 1 Projects Releases Wiki Activity

clockselect: Remove non-sense comment

Browse source 
Commentary appears to assume `gst_harness_find_element` return value was
"transfer none", but it is not the case. So, element must be unrefed
before the end.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1009>
This commit is contained in:
Ederson de Souza 2020-01-27 15:16:12 -08:00 committed by GStreamer Merge Bot
parent b769af0c4f
commit 443c01e119
1 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tests/check/elements/clockselect.c
View file

@ -39,8 +39,6 @@ GST_START_TEST (test_clock_select_realtime_clock)
g_object_get (G_OBJECT (clock), "clock-type", &clock_type, NULL);
fail_unless_equals_uint64 (clock_type, GST_CLOCK_TYPE_REALTIME);
/* Unref this element to shut up valgrind. But it looks weird, maybe
* some funny harness bug due clockselect being a bin? */
gst_object_unref (element);
gst_object_unref (clock);
gst_harness_teardown (h);
@ -65,7 +63,6 @@ GST_START_TEST (test_clock_select_monotonic_clock)
g_object_get (G_OBJECT (clock), "clock-type", &clock_type, NULL);
fail_unless_equals_uint64 (clock_type, GST_CLOCK_TYPE_MONOTONIC);
/* See comment on test_clock_select_realtime_clock about this unref */
gst_object_unref (element);
gst_object_unref (clock);
gst_harness_teardown (h);
@ -89,7 +86,6 @@ GST_START_TEST (test_clock_select_properties)
g_object_get (G_OBJECT (element), "ptp-domain", &domain, NULL);
fail_unless_equals_uint64 (domain, 2);
/* See comment on test_clock_select_realtime_clock about this unref */
gst_object_unref (element);
gst_harness_teardown (h);
}