mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-10-06 18:52:07 +00:00
miniobjects: Don't chain up to empty finalize method.
If ever we do anything in mini_object_finalize, we should make sure the 4 core miniobject finalize methods chain back up again.
This commit is contained in:
parent
5d819beffb
commit
43dba6cefc
5 changed files with 13 additions and 5 deletions
|
@ -165,8 +165,8 @@ gst_buffer_finalize (GstBuffer * buffer)
|
||||||
|
|
||||||
gst_caps_replace (&GST_BUFFER_CAPS (buffer), NULL);
|
gst_caps_replace (&GST_BUFFER_CAPS (buffer), NULL);
|
||||||
|
|
||||||
((GstMiniObjectClass *)
|
/* ((GstMiniObjectClass *) */
|
||||||
gst_buffer_parent_class)->finalize (GST_MINI_OBJECT_CAST (buffer));
|
/* gst_buffer_parent_class)->finalize (GST_MINI_OBJECT_CAST (buffer)); */
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|
|
@ -231,7 +231,7 @@ gst_event_finalize (GstEvent * event)
|
||||||
gst_structure_free (event->structure);
|
gst_structure_free (event->structure);
|
||||||
}
|
}
|
||||||
|
|
||||||
GST_MINI_OBJECT_CLASS (parent_class)->finalize (GST_MINI_OBJECT (event));
|
/* GST_MINI_OBJECT_CLASS (parent_class)->finalize (GST_MINI_OBJECT (event)); */
|
||||||
}
|
}
|
||||||
|
|
||||||
static GstEvent *
|
static GstEvent *
|
||||||
|
|
|
@ -207,7 +207,7 @@ gst_message_finalize (GstMessage * message)
|
||||||
gst_structure_free (message->structure);
|
gst_structure_free (message->structure);
|
||||||
}
|
}
|
||||||
|
|
||||||
GST_MINI_OBJECT_CLASS (parent_class)->finalize (GST_MINI_OBJECT (message));
|
/* GST_MINI_OBJECT_CLASS (parent_class)->finalize (GST_MINI_OBJECT (message)); */
|
||||||
}
|
}
|
||||||
|
|
||||||
static GstMessage *
|
static GstMessage *
|
||||||
|
|
|
@ -159,6 +159,14 @@ static void
|
||||||
gst_mini_object_finalize (GstMiniObject * obj)
|
gst_mini_object_finalize (GstMiniObject * obj)
|
||||||
{
|
{
|
||||||
/* do nothing */
|
/* do nothing */
|
||||||
|
|
||||||
|
/* WARNING: if anything is ever put in this method, make sure that the
|
||||||
|
* following sub-classes' finalize method chains up to this one:
|
||||||
|
* gstbuffer
|
||||||
|
* gstevent
|
||||||
|
* gstmessage
|
||||||
|
* gstquery
|
||||||
|
*/
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|
|
@ -191,7 +191,7 @@ gst_query_finalize (GstQuery * query)
|
||||||
gst_structure_free (query->structure);
|
gst_structure_free (query->structure);
|
||||||
}
|
}
|
||||||
|
|
||||||
GST_MINI_OBJECT_CLASS (parent_class)->finalize (GST_MINI_OBJECT (query));
|
/* GST_MINI_OBJECT_CLASS (parent_class)->finalize (GST_MINI_OBJECT (query)); */
|
||||||
}
|
}
|
||||||
|
|
||||||
static GstQuery *
|
static GstQuery *
|
||||||
|
|
Loading…
Reference in a new issue