mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-02 00:32:43 +00:00
Code Issues 1 Projects Releases Wiki Activity

id3tag: fix sample memory leak

Browse source 
When getting sample from taglist, the memory is not being freed resulting in memory leak.

https://bugzilla.gnome.org/show_bug.cgi?id=756070
This commit is contained in:
Vineeth TM 2015-10-05 11:21:07 +09:00 committed by Sebastian Dröge
parent cb20105aa5
commit 43ce0c3142
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gst/id3tag/id3tag.c
View file

@ -498,8 +498,10 @@ add_id3v2frame_tag (GstId3v2Tag * id3v2tag, const GstTagList * list,
guint8 *data;
gint size;
if (!gst_buffer_map (buf, &mapinfo, GST_MAP_READ))
if (!gst_buffer_map (buf, &mapinfo, GST_MAP_READ)) {
gst_sample_unref (sample);
continue;
}
size = mapinfo.size;
data = mapinfo.data;
@ -526,6 +528,7 @@ add_id3v2frame_tag (GstId3v2Tag * id3v2tag, const GstTagList * list,
"version");
}
}
gst_sample_unref (sample);
}
}
@ -777,6 +780,7 @@ add_image_tag (GstId3v2Tag * id3v2tag, const GstTagList * list,
} else {
GST_WARNING ("no image or caps: %p, caps=%" GST_PTR_FORMAT, image, caps);
}
gst_sample_unref (sample);
}
}