rtpptdemux: Don't GST_FLOW_ERROR when ignoring invalid packets

https://bugzilla.gnome.org/show_bug.cgi?id=741398 changed
rtpptdemux in 2014 to not post a GST_ELEMENT_ERROR on the
bus when dropping an invalid (non-RTP) packet, but still
returned GST_FLOW_ERROR upstream - so the pipeline still
stops, but now without a useful bus error.

Return GST_FLOW_OK instead, so the pipeline keeps
running. Some old telephony equipment can send invalid
packets before the real RTP traffic starts.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2523>
This commit is contained in:
Jan Schmidt 2022-05-29 20:27:38 +10:00 committed by Tim-Philipp Müller
parent 8eb3f2a74c
commit 42bb70a2df

View file

@ -567,7 +567,7 @@ invalid_buffer:
GST_ELEMENT_WARNING (rtpdemux, STREAM, DEMUX, (NULL),
("Dropping invalid RTP payload"));
gst_buffer_unref (buf);
return GST_FLOW_ERROR;
return GST_FLOW_OK;
}
no_caps:
{