mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-23 16:50:47 +00:00
Code Issues 1 Projects Releases Wiki Activity

cvvideofilter: Don't try to make buffer writable

Browse source 
First this is handle by base transform, hence this is a no-op, and if it wasn't it
would lead to a buffer copy being leaked, and then an unreffed buffer being
pushed downstream.

https://bugzilla.gnome.org/show_bug.cgi?id=732756
This commit is contained in:
Nicolas Dufresne 2014-07-04 20:31:50 -04:00
parent 2acdb2ecf2
commit 42a83d2c64
1 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ext/opencv/gstopencvvideofilter.c
View file

@ -217,15 +217,11 @@ gst_opencv_video_filter_transform_ip (GstBaseTransform * trans,
g_return_val_if_fail (fclass->cv_trans_ip_func != NULL, GST_FLOW_ERROR); g_return_val_if_fail (fclass->cv_trans_ip_func != NULL, GST_FLOW_ERROR);
g_return_val_if_fail (transform->cvImage != NULL, GST_FLOW_ERROR); g_return_val_if_fail (transform->cvImage != NULL, GST_FLOW_ERROR);
/* TODO this is not always needed and should be solved at BaseTransform
* level */
buffer = gst_buffer_make_writable (buffer);
if (!gst_buffer_map (buffer, &info, GST_MAP_READWRITE)) if (!gst_buffer_map (buffer, &info, GST_MAP_READWRITE))
goto map_failed; goto map_failed;
transform->cvImage->imageData = (char *) info.data; transform->cvImage->imageData = (char *) info.data;
/* FIXME how to release buffer? */
ret = fclass->cv_trans_ip_func (transform, buffer, transform->cvImage); ret = fclass->cv_trans_ip_func (transform, buffer, transform->cvImage);
gst_buffer_unmap (buffer, &info); gst_buffer_unmap (buffer, &info);