mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-20 08:41:07 +00:00
Code Issues 1 Projects Releases Wiki Activity

waylandsink: Add a comment about dmabuf without feature

Browse source 
The code does not make it obvious that dmabuf is still supported
without the feature. This documents that it is supported, but
only for formats that are also support by SHM interface.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3476>
This commit is contained in:
Nicolas Dufresne 2022-11-28 09:00:27 -05:00 committed by GStreamer Marge Bot
parent 5441b77683
commit 413ceb060f
2 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
subprojects/gst-plugins-bad/ext/gtk/gstgtkwaylandsink.c
View file

@ -958,6 +958,9 @@ gst_gtk_wayland_sink_set_caps (GstBaseSink * bsink, GstCaps * caps)
if (!gst_wl_display_check_format_for_dmabuf (priv->display, format)) if (!gst_wl_display_check_format_for_dmabuf (priv->display, format))
goto unsupported_format; goto unsupported_format;
} else if (!gst_wl_display_check_format_for_shm (priv->display, format)) { } else if (!gst_wl_display_check_format_for_shm (priv->display, format)) {
/* Note: we still support dmabuf in this case, but formats must also be
* supported on SHM interface to ensure a fallback is possible as we are
* not guarantied we'll get dmabuf in the buffers. */
goto unsupported_format; goto unsupported_format;
} }

3
subprojects/gst-plugins-bad/ext/wayland/gstwaylandsink.c
View file

@ -717,6 +717,9 @@ gst_wayland_sink_set_caps (GstBaseSink * bsink, GstCaps * caps)
if (!gst_wl_display_check_format_for_dmabuf (self->display, format)) if (!gst_wl_display_check_format_for_dmabuf (self->display, format))
goto unsupported_format; goto unsupported_format;
} else if (!gst_wl_display_check_format_for_shm (self->display, format)) { } else if (!gst_wl_display_check_format_for_shm (self->display, format)) {
/* Note: we still support dmabuf in this case, but formats must also be
* supported on SHM interface to ensure a fallback is possible as we are
* not guarantied we'll get dmabuf in the buffers. */
goto unsupported_format; goto unsupported_format;
} }