mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-24 08:08:22 +00:00
Code Issues 1 Projects Releases Wiki Activity

simplevideomark: refactor code

Browse source 
the calculations for drawing the videomark is being repeated
in for loop unnecessarily. Moving this outside of for loop
such that the code need not be executed evertime the loop is executed.

https://bugzilla.gnome.org/show_bug.cgi?id=744371
This commit is contained in:
Vineeth T M 2015-02-12 12:04:44 +05:30 committed by Thiago Santos
parent b347ea9870
commit 413a60959d
1 changed files with 11 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
gst/videosignal/gstsimplevideomark.c
View file

@ -359,15 +359,13 @@ gst_video_mark_yuv (GstSimpleVideoMark * simplevideomark, GstVideoFrame * frame)
return GST_FLOW_ERROR;
}
d = GST_VIDEO_FRAME_COMP_DATA (frame, 0);
/* move to start of bottom left */
d += row_stride * (height - ph - simplevideomark->bottom_offset) +
pixel_stride * simplevideomark->left_offset;
/* draw the bottom left pixels */
for (i = 0; i < simplevideomark->pattern_count; i++) {
d = GST_VIDEO_FRAME_COMP_DATA (frame, 0);
/* move to start of bottom left */
d += row_stride * (height - ph - simplevideomark->bottom_offset) +
pixel_stride * simplevideomark->left_offset;
/* move to i-th pattern */
d += pixel_stride * pw * i;
if (i & 1)
/* odd pixels must be white */
color = 255;
@ -377,6 +375,9 @@ gst_video_mark_yuv (GstSimpleVideoMark * simplevideomark, GstVideoFrame * frame)
/* draw box of width * height */
gst_video_mark_draw_box (simplevideomark, d, pw, ph, row_stride,
pixel_stride, color);
/* move to i-th pattern */
d += pixel_stride * pw;
}
pattern_shift =
@ -384,15 +385,6 @@ gst_video_mark_yuv (GstSimpleVideoMark * simplevideomark, GstVideoFrame * frame)
/* get the data of the pattern */
for (i = 0; i < simplevideomark->pattern_data_count; i++) {
d = GST_VIDEO_FRAME_COMP_DATA (frame, 0);
/* move to start of bottom left, adjust for offsets */
d += row_stride * (height - ph - simplevideomark->bottom_offset) +
pixel_stride * simplevideomark->left_offset;
/* move after the fixed pattern */
d += pixel_stride * simplevideomark->pattern_count * pw;
/* move to i-th pattern data */
d += pixel_stride * pw * i;
if (simplevideomark->pattern_data & pattern_shift)
color = 255;
else
@ -402,6 +394,9 @@ gst_video_mark_yuv (GstSimpleVideoMark * simplevideomark, GstVideoFrame * frame)
pixel_stride, color);
pattern_shift >>= 1;
/* move to i-th pattern data */
d += pixel_stride * pw;
}
return GST_FLOW_OK;