mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-18 05:16:05 +00:00
Code Issues 1 Projects Releases Wiki Activity

omxbufferpool: add PERFORMANCE DEBUG message when copying output frames

Browse source 
I spent quiet some time figuring out why performance of my pipeline were
terrible. Turned out it was because of output frames being copied
because of stride/offset mismatch.

Add a PERFORMANCE DEBUG message to make it easier to spot and debug from logs.

https://bugzilla.gnome.org/show_bug.cgi?id=793637
This commit is contained in:
Guillaume Desmottes 2018-02-20 11:46:49 +01:00 committed by Tim-Philipp Müller
parent c6a112ec93
commit 412df8c74f
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
omx/gstomxbufferpool.c
View file

@ -30,6 +30,7 @@
GST_DEBUG_CATEGORY_STATIC (gst_omx_buffer_pool_debug_category); GST_DEBUG_CATEGORY_STATIC (gst_omx_buffer_pool_debug_category);
#define GST_CAT_DEFAULT gst_omx_buffer_pool_debug_category #define GST_CAT_DEFAULT gst_omx_buffer_pool_debug_category
GST_DEBUG_CATEGORY_STATIC (CAT_PERFORMANCE);
typedef struct _GstOMXMemory GstOMXMemory; typedef struct _GstOMXMemory GstOMXMemory;
typedef struct _GstOMXMemoryAllocator GstOMXMemoryAllocator; typedef struct _GstOMXMemoryAllocator GstOMXMemoryAllocator;
@ -462,6 +463,12 @@ gst_omx_buffer_pool_alloc_buffer (GstBufferPool * bpool,
for (i = 0; i < GST_VIDEO_INFO_N_PLANES (&pool->video_info); i++) { for (i = 0; i < GST_VIDEO_INFO_N_PLANES (&pool->video_info); i++) {
if (info.stride[i] != stride[i] || info.offset[i] != offset[i]) { if (info.stride[i] != stride[i] || info.offset[i] != offset[i]) {
GST_CAT_DEBUG_OBJECT (CAT_PERFORMANCE, pool,
"Need to copy output frames because of stride/offset mismatch: plane %d stride %d (expected: %d) offset %"
G_GSIZE_FORMAT " (expected: %" G_GSIZE_FORMAT
") nStride: %d nSliceHeight: %d ", i, stride[i], info.stride[i],
offset[i], info.offset[i], nstride, nslice);
need_copy = TRUE; need_copy = TRUE;
break; break;
} }
@ -647,6 +654,8 @@ gst_omx_buffer_pool_class_init (GstOMXBufferPoolClass * klass)
gstbufferpool_class->free_buffer = gst_omx_buffer_pool_free_buffer; gstbufferpool_class->free_buffer = gst_omx_buffer_pool_free_buffer;
gstbufferpool_class->acquire_buffer = gst_omx_buffer_pool_acquire_buffer; gstbufferpool_class->acquire_buffer = gst_omx_buffer_pool_acquire_buffer;
gstbufferpool_class->release_buffer = gst_omx_buffer_pool_release_buffer; gstbufferpool_class->release_buffer = gst_omx_buffer_pool_release_buffer;
GST_DEBUG_CATEGORY_GET (CAT_PERFORMANCE, "GST_PERFORMANCE");
} }
static void static void