mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-24 18:51:11 +00:00
Code Issues 1 Projects Releases Wiki Activity

gsturi: unescape '=' in http query

Browse source 
Don't use percent-encoding for '=' in http queries.
'=' in the following kind of http query should be maintained.
example:
?token=exp=123~acl=/QualityLevels(*~hmac=0cb ...

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/580>
This commit is contained in:
Hosang Lee 2020-07-28 10:59:35 +09:00 committed by GStreamer Merge Bot
parent edcbc7cc98
commit 411d255154
2 changed files with 24 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gst/gsturi.c
View file

@ -1265,7 +1265,7 @@ _gst_uri_escape_http_query_element (const gchar * element)
{
gchar *ret, *c;
ret = g_uri_escape_string (element, "!$'()*,;:@/? ", FALSE);
ret = g_uri_escape_string (element, "!$'()*,;:@/?= ", FALSE);
for (c = ret; *c; c++)
if (*c == ' ')
*c = '+';

23
tests/check/gst/gsturi.c
View file

@ -1108,6 +1108,28 @@ GST_START_TEST (test_url_get_media_fragment_table)
GST_END_TEST;
GST_START_TEST (test_url_unescape_equals_in_http_query)
{
GstUri *url;
gchar *query_string;
url =
gst_uri_from_string
("http://abc.manifest?token=exp=123~acl=/QualityLevels(*~hmac=0cb");
fail_unless_equals_string (gst_uri_get_scheme (url), "http");
query_string = gst_uri_get_query_string (url);
fail_unless_equals_string (query_string,
"token=exp=123~acl=/QualityLevels(*~hmac=0cb");
g_free (query_string);
fail_unless (gst_uri_query_has_key (url, "token"));
fail_unless_equals_string (gst_uri_get_query_value (url, "token"),
"exp=123~acl=/QualityLevels(*~hmac=0cb");
gst_uri_unref (url);
}
GST_END_TEST;
static Suite *
gst_uri_suite (void)
{
@ -1135,6 +1157,7 @@ gst_uri_suite (void)
tcase_add_test (tc_chain, test_url_constructors);
tcase_add_test (tc_chain, test_url_get_set);
tcase_add_test (tc_chain, test_url_get_media_fragment_table);
tcase_add_test (tc_chain, test_url_unescape_equals_in_http_query);
return s;
}