mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-07 07:58:51 +00:00
Code Issues 1 Projects Releases Wiki Activity

typefindfunctions: Check for the SVG namespace URL in addition to <svg and the doctype

Browse source 
Finding the SVG namespace URL gives a clear indication that this is
actually an SVG file while the `<svg>` tag only gives a likely
indication as it's rather short.

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1540

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3631>
This commit is contained in:
Sebastian Dröge 2022-12-23 16:15:49 +02:00 committed by GStreamer Marge Bot
parent 5ff5f9fd5b
commit 401ea9f683
1 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
subprojects/gst-plugins-base/gst/typefind/gsttypefindfunctions.c
View file

@ -2162,21 +2162,29 @@ svg_type_find (GstTypeFind * tf, gpointer unused)
{ {
static const gchar svg_doctype[] = "!DOCTYPE svg"; static const gchar svg_doctype[] = "!DOCTYPE svg";
static const gchar svg_tag[] = "<svg"; static const gchar svg_tag[] = "<svg";
static const gchar svg_namespace[] = "http://www.w3.org/2000/svg";
DataScanCtx c = { 0, NULL, 0 }; DataScanCtx c = { 0, NULL, 0 };
guint probability = GST_TYPE_FIND_NONE;
while (c.offset <= 1024) { while (c.offset <= 1024) {
if (G_UNLIKELY (!data_scan_ctx_ensure_data (tf, &c, 12))) if (G_UNLIKELY (!data_scan_ctx_ensure_data (tf, &c,
strlen (svg_namespace))))
break; break;
if (memcmp (svg_doctype, c.data, 12) == 0) { if (memcmp (svg_doctype, c.data, 12) == 0
|| memcmp (svg_namespace, c.data, strlen (svg_namespace)) == 0) {
gst_type_find_suggest (tf, GST_TYPE_FIND_MAXIMUM, SVG_CAPS); gst_type_find_suggest (tf, GST_TYPE_FIND_MAXIMUM, SVG_CAPS);
return; return;
} else if (memcmp (svg_tag, c.data, 4) == 0) { } else if (memcmp (svg_tag, c.data, 4) == 0) {
gst_type_find_suggest (tf, GST_TYPE_FIND_LIKELY, SVG_CAPS); // Check if we also find the SVG namespace later as that would be a
return; // clearer indication
probability = GST_TYPE_FIND_LIKELY;
} }
data_scan_ctx_advance (tf, &c, 1); data_scan_ctx_advance (tf, &c, 1);
} }
if (probability > GST_TYPE_FIND_NONE)
gst_type_find_suggest (tf, probability, SVG_CAPS);
} }
/*** multipart/x-mixed-replace mimestream ***/ /*** multipart/x-mixed-replace mimestream ***/