don't put strerror in translatable message

Original commit message from CVS:

don't put strerror in translatable message
This commit is contained in:
Thomas Vander Stichele 2006-11-04 12:54:08 +00:00
parent f24b0e54a0
commit 3ff099d23e
3 changed files with 11 additions and 2 deletions

View file

@ -1,3 +1,9 @@
2006-11-04 Thomas Vander Stichele <thomas at apestaart dot org>
* plugins/elements/gstfilesrc.c: (gst_file_src_start):
I'm considering shooting the next person to put strerror stuff
in the translateable part of the message.
2006-11-03 Wim Taymans <wim@fluendo.com>
* plugins/elements/gstfdsrc.c: (gst_fd_src_create):

View file

@ -124,6 +124,9 @@ CHECKLIST
- message strings need to be marked for translation
- should be short, well-written, clear
- in particular, should *not* contain debug info, strerror, errno, ...
No, really ! NO STRERROR, NO ERRNO. If you are too lazy to provide
the user of your library with a nice experience, put your crap in
the debug string
- Decision should be made if it should go into good (LGPL license,
LGPL dependencies, no patent issues) or ugly

View file

@ -975,8 +975,8 @@ open_failed:
break;
default:
GST_ELEMENT_ERROR (src, RESOURCE, OPEN_READ,
(_("Could not open file \"%s\" for reading: %s."), src->filename,
strerror (errno)), GST_ERROR_SYSTEM);
(_("Could not open file \"%s\" for reading."), src->filename),
GST_ERROR_SYSTEM);
break;
}
return FALSE;