mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-11 01:45:33 +00:00
Code Issues 1 Projects Releases Wiki Activity

gst/gstelement.c: Clear the pad caps when the element shut down all of the pads and is not streaming data that could ...

Browse source 
Original commit message from CVS:
* gst/gstelement.c: (activate_pads), (clear_caps),
(iterator_activate_fold_with_resync), (gst_element_pads_activate):
Clear the pad caps when the element shut down all of the pads and
is not streaming data that could modify the caps.
Fixes #352958.
This commit is contained in:
Wim Taymans 2006-08-29 09:56:57 +00:00
parent 06f437a40c
commit 3f7a406618
2 changed files with 42 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ChangeLog
View file

@ -1,3 +1,11 @@
2006-08-29 Wim Taymans <wim@fluendo.com>
* gst/gstelement.c: (activate_pads), (clear_caps),
(iterator_activate_fold_with_resync), (gst_element_pads_activate):
Clear the pad caps when the element shut down all of the pads and
is not streaming data that could modify the caps.
Fixes #352958.
2006-08-28 Michael Smith <msmith@fluendo.com>
* plugins/elements/gstidentity.c: (gst_identity_transform_ip):

41
gst/gstelement.c
View file

@ -2260,19 +2260,27 @@ activate_pads (GstPad * pad, GValue * ret, gboolean * active)
{
if (!gst_pad_set_active (pad, *active))
g_value_set_boolean (ret, FALSE);
else if (!*active)
gst_pad_set_caps (pad, NULL);
/* unref the object that was reffed for us by _fold */
gst_object_unref (pad);
return TRUE;
}
/* set the caps on the pad to NULL */
static gboolean
clear_caps (GstPad * pad, GValue * ret, gboolean * active)
{
gst_pad_set_caps (pad, NULL);
gst_object_unref (pad);
return TRUE;
}
/* returns false on error or early cutout (will never happen because the fold
* function always returns TRUE, see FIXME above) of the fold, true if all
* pads in @iter were (de)activated successfully. */
static gboolean
iterator_activate_fold_with_resync (GstIterator * iter, gpointer user_data)
iterator_activate_fold_with_resync (GstIterator * iter,
GstIteratorFoldFunction func, gpointer user_data)
{
GstIteratorResult ires;
GValue ret = { 0 };
@ -2282,8 +2290,7 @@ iterator_activate_fold_with_resync (GstIterator * iter, gpointer user_data)
g_value_set_boolean (&ret, TRUE);
while (1) {
ires = gst_iterator_fold (iter, (GstIteratorFoldFunction) activate_pads,
&ret, user_data);
ires = gst_iterator_fold (iter, func, &ret, user_data);
switch (ires) {
case GST_ITERATOR_RESYNC:
/* need to reset the result again */
@ -2318,17 +2325,32 @@ gst_element_pads_activate (GstElement * element, gboolean active)
GST_DEBUG_OBJECT (element, "pads_activate with active %d", active);
iter = gst_element_iterate_src_pads (element);
res = iterator_activate_fold_with_resync (iter, &active);
res =
iterator_activate_fold_with_resync (iter,
(GstIteratorFoldFunction) activate_pads, &active);
gst_iterator_free (iter);
if (G_UNLIKELY (!res))
goto src_failed;
iter = gst_element_iterate_sink_pads (element);
res = iterator_activate_fold_with_resync (iter, &active);
res =
iterator_activate_fold_with_resync (iter,
(GstIteratorFoldFunction) activate_pads, &active);
gst_iterator_free (iter);
if (G_UNLIKELY (!res))
goto sink_failed;
if (!active) {
/* clear the caps on all pads, this should never fail */
iter = gst_element_iterate_pads (element);
res =
iterator_activate_fold_with_resync (iter,
(GstIteratorFoldFunction) clear_caps, &active);
gst_iterator_free (iter);
if (G_UNLIKELY (!res))
goto caps_failed;
}
GST_DEBUG_OBJECT (element, "pads_activate successful");
return TRUE;
@ -2344,6 +2366,11 @@ sink_failed:
GST_DEBUG_OBJECT (element, "sink pads_activate failed");
return FALSE;
}
caps_failed:
{
GST_DEBUG_OBJECT (element, "failed to clear caps on pads");
return FALSE;
}
}
/* is called with STATE_LOCK */