mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-23 02:01:12 +00:00
Code Issues 1 Projects Releases Wiki Activity

sdpdemux: ensure that only one srcpad is created per stream

Browse source 
If two senders use the same multicast IP and port then new_session_pad()
may try to add a srcpad to the same stream twice.

stream->srcpad is updated but gst_element_add_pad() fails the second
time. As a result stream->srcpad points to a deleted object and
access in gst_sdp_demux_stream_free() fails with a segfault.

Just ignore the second pad. Nothing useful can be done with it anyway.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4603>
This commit is contained in:
Michael Olbrich 2023-05-11 15:28:35 +02:00 committed by GStreamer Marge Bot
parent 17f297bac2
commit 3f24a38c8e
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
subprojects/gst-plugins-bad/gst/sdp/gstsdpdemux.c
View file

@ -811,6 +811,9 @@ new_session_pad (GstElement * session, GstPad * pad, GstSDPDemux * demux)
if (stream == NULL) if (stream == NULL)
goto unknown_stream; goto unknown_stream;
if (stream->srcpad)
goto unexpected_pad;
stream->ssrc = ssrc; stream->ssrc = ssrc;
/* no need for a timeout anymore now */ /* no need for a timeout anymore now */
@ -851,6 +854,13 @@ new_session_pad (GstElement * session, GstPad * pad, GstSDPDemux * demux)
return; return;
/* ERRORS */ /* ERRORS */
unexpected_pad:
{
GST_DEBUG_OBJECT (demux, "ignoring unexpected session pad");
GST_SDP_STREAM_UNLOCK (demux);
g_free (name);
return;
}
unknown_stream: unknown_stream:
{ {
GST_DEBUG_OBJECT (demux, "ignoring unknown stream"); GST_DEBUG_OBJECT (demux, "ignoring unknown stream");