mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-08 16:35:40 +00:00
Code Issues 1 Projects Releases Wiki Activity

v4l2: pool: Adjust pool behaviour when DMA_DRM is used

Browse source 
We disable the copy threshold and always add GstVideoMeta.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7633>
This commit is contained in:
Nicolas Dufresne 2024-12-18 15:13:17 -05:00 committed by GStreamer Marge Bot
parent 77744c3d63
commit 3ec1feb88f
2 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
subprojects/gst-plugins-good/sys/v4l2/gstv4l2bufferpool.c
View file

@ -526,15 +526,19 @@ gst_v4l2_buffer_pool_set_config (GstBufferPool * bpool, GstStructure * config)
gboolean updated = FALSE;
gboolean ret;
pool->add_videometa =
gst_buffer_pool_config_has_option (config,
GST_BUFFER_POOL_OPTION_VIDEO_META);
/* parse the config and keep around */
if (!gst_buffer_pool_config_get_params (config, &caps, &size, &min_buffers,
&max_buffers))
goto wrong_config;
pool->add_videometa =
gst_buffer_pool_config_has_option (config,
GST_BUFFER_POOL_OPTION_VIDEO_META);
/* Always enable VideoMeta when we negotiate memory:DMABuf */
pool->have_dma_drm_caps = gst_video_is_dma_drm_caps (caps);
pool->add_videometa |= pool->have_dma_drm_caps;
if (!gst_buffer_pool_config_get_allocator (config, &allocator, &params))
goto wrong_config;
@ -2258,7 +2262,8 @@ void
gst_v4l2_buffer_pool_copy_at_threshold (GstV4l2BufferPool * pool, gboolean copy)
{
GST_OBJECT_LOCK (pool);
pool->enable_copy_threshold = copy;
/* Ignore copy threashold when memory:DMABuf caps features is in used */
pool->enable_copy_threshold = copy && !pool->have_dma_drm_caps;
GST_OBJECT_UNLOCK (pool);
}

1
subprojects/gst-plugins-good/sys/v4l2/gstv4l2bufferpool.h
View file

@ -76,6 +76,7 @@ struct _GstV4l2BufferPool
GstBufferPool *other_pool;
guint size;
GstVideoInfo caps_info; /* Default video information */
gboolean have_dma_drm_caps; /* If the configured caps have memory:DMABuf */
gboolean add_videometa; /* set if video meta should be added */
gboolean enable_copy_threshold; /* If copy_threshold should be set */