mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-27 12:11:13 +00:00
Code Issues 1 Projects Releases Wiki Activity

avimux: write correct blockalign for vbr audio

Browse source 
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=720659
This commit is contained in:
Mark Nauwelaerts 2014-01-19 17:38:59 +01:00
parent cdbb2ba6b8
commit 3ea338ce27
2 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
gst/avi/gstavimux.c
View file

@ -712,8 +712,9 @@ gst_avi_mux_audsink_set_fields (GstAviMux * avimux, GstAviAudioPad * avipad)
/* vbr case: fixed duration per frame/chunk */
avipad->parent.hdr.rate = avipad->auds.rate;
avipad->parent.hdr.samplesize = 0;
/* FIXME ?? some rumours say this should be largest audio chunk size */
avipad->auds.blockalign = avipad->parent.hdr.scale;
/* this triggers determining largest audio chunk size to write at end */
avipad->max_audio_chunk = avipad->auds.blockalign =
avipad->parent.hdr.scale;
} else {
/* by spec, hdr.rate is av_bps related, is calculated that way in stop_file,
* and reduces to sample rate in PCM like cases */
@ -1811,6 +1812,9 @@ gst_avi_mux_stop_file (GstAviMux * avimux)
audpad->auds.av_bps = 0;
}
}
/* housekeeping for vbr case */
if (audpad->max_audio_chunk)
audpad->auds.blockalign = audpad->max_audio_chunk;
gst_avi_mux_audsink_set_fields (avimux, audpad);
avimux->avi_hdr.max_bps += audpad->auds.av_bps;
avipad->hdr.length = gst_util_uint64_scale (audpad->audio_time,
@ -2089,6 +2093,8 @@ gst_avi_mux_do_buffer (GstAviMux * avimux, GstAviPad * avipad)
flags = 0;
audpad->audio_size += datasize;
audpad->audio_time += GST_BUFFER_DURATION (data);
if (audpad->max_audio_chunk && datasize > audpad->max_audio_chunk)
audpad->max_audio_chunk = datasize;
}
gst_avi_mux_add_index (avimux, avipad, flags, datasize);

2
gst/avi/gstavimux.h
View file

@ -117,6 +117,8 @@ typedef struct _GstAviAudioPad {
/* audio info for bps calculation */
guint32 audio_size;
guint64 audio_time;
/* max audio chunk size for vbr */
guint32 max_audio_chunk;
/* counts the number of samples to put in indx chunk
* useful for raw audio where usually there are more than