mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-18 22:36:33 +00:00
Code Issues 1 Projects Releases Wiki Activity

pipeline: Check that the profile could actually be set on the encodebin

Browse source 
Setting the profile on an encodebin can fail, and if that happens, there
will be no profile set at all, we should return FALSE in GESPipeline
when that happens
This commit is contained in:
Thibault Saunier 2013-07-21 21:41:13 -04:00
parent 9f0b0c26e3
commit 3e88edfebc
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
ges/ges-pipeline.c
View file

@ -879,6 +879,7 @@ ges_pipeline_set_render_settings (GESPipeline * pipeline,
const gchar * output_uri, GstEncodingProfile * profile) const gchar * output_uri, GstEncodingProfile * profile)
{ {
GError *err = NULL; GError *err = NULL;
GstEncodingProfile *set_profile;
g_return_val_if_fail (GES_IS_TIMELINE_PIPELINE (pipeline), FALSE); g_return_val_if_fail (GES_IS_TIMELINE_PIPELINE (pipeline), FALSE);
@ -905,8 +906,17 @@ ges_pipeline_set_render_settings (GESPipeline * pipeline,
g_object_set (pipeline->priv->encodebin, "avoid-reencoding", g_object_set (pipeline->priv->encodebin, "avoid-reencoding",
!(!(pipeline->priv->mode & TIMELINE_MODE_SMART_RENDER)), NULL); !(!(pipeline->priv->mode & TIMELINE_MODE_SMART_RENDER)), NULL);
g_object_set (pipeline->priv->encodebin, "profile", profile, NULL); g_object_set (pipeline->priv->encodebin, "profile", profile, NULL);
pipeline->priv->profile = g_object_get (pipeline->priv->encodebin, "profile", &set_profile, NULL);
(GstEncodingProfile *) gst_encoding_profile_ref (profile);
if (set_profile == NULL) {
GST_ERROR_OBJECT (pipeline, "Profile %" GST_PTR_FORMAT " could no be set",
profile);
return FALSE;
}
/* We got a referencer when getting back the profile */
pipeline->priv->profile = profile;
return TRUE; return TRUE;
} }