mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-07 07:58:51 +00:00
Code Issues 1 Projects Releases Wiki Activity

wasapi2: Fix task memory leak

Browse source 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6218>
This commit is contained in:
Seungha Yang 2024-02-21 21:46:49 +09:00 committed by GStreamer Marge Bot
parent b793c3e03b
commit 3bc068473b
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
subprojects/gst-plugins-bad/sys/wasapi2/gstwasapi2ringbuffer.cpp
View file

@ -973,6 +973,7 @@ gst_wasapi2_ring_buffer_prepare_loopback_client (GstWasapi2RingBuffer * self)
hr = gst_wasapi2_ring_buffer_initialize_audio_client (self, client_handle, hr = gst_wasapi2_ring_buffer_initialize_audio_client (self, client_handle,
mix_format, &period, 0, GST_WASAPI2_CLIENT_DEVICE_CLASS_RENDER, mix_format, &period, 0, GST_WASAPI2_CLIENT_DEVICE_CLASS_RENDER,
nullptr, FALSE); nullptr, FALSE);
CoTaskMemFree (mix_format);
if (!gst_wasapi2_result (hr)) { if (!gst_wasapi2_result (hr)) {
GST_ERROR_OBJECT (self, "Failed to initialize audio client"); GST_ERROR_OBJECT (self, "Failed to initialize audio client");
@ -1117,8 +1118,6 @@ gst_wasapi2_ring_buffer_acquire (GstAudioRingBuffer * buf,
gst_audio_ring_buffer_set_channel_positions (buf, position); gst_audio_ring_buffer_set_channel_positions (buf, position);
g_free (position); g_free (position);
CoTaskMemFree (mix_format);
if (!gst_wasapi2_result (hr)) { if (!gst_wasapi2_result (hr)) {
GST_ERROR_OBJECT (self, "Failed to init audio client"); GST_ERROR_OBJECT (self, "Failed to init audio client");
goto error; goto error;
@ -1184,12 +1183,15 @@ gst_wasapi2_ring_buffer_acquire (GstAudioRingBuffer * buf,
gst_audio_format_info_fill_silence (buf->spec.info.finfo, gst_audio_format_info_fill_silence (buf->spec.info.finfo,
buf->memory, buf->size); buf->memory, buf->size);
CoTaskMemFree (mix_format);
return TRUE; return TRUE;
error: error:
GST_WASAPI2_CLEAR_COM (self->render_client); GST_WASAPI2_CLEAR_COM (self->render_client);
GST_WASAPI2_CLEAR_COM (self->capture_client); GST_WASAPI2_CLEAR_COM (self->capture_client);
GST_WASAPI2_CLEAR_COM (self->volume_object); GST_WASAPI2_CLEAR_COM (self->volume_object);
CoTaskMemFree (mix_format);
gst_wasapi2_ring_buffer_post_open_error (self); gst_wasapi2_ring_buffer_post_open_error (self);