mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-03 01:02:19 +00:00
Code Issues 1 Projects Releases Wiki Activity

deinterlace: Don't pointlessly hold object lock over caps operations

Browse source 
Avoids a deadlock when getcaps is recursive due to the getcaps being
reflected upstream/downstream. The lock isn't actually protecting
anything here.
This commit is contained in:
Jan Schmidt 2011-10-28 00:41:45 +11:00
parent f6255bb8d0
commit 3b03db5e40
1 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gst/deinterlace/gstdeinterlace.c
View file

@ -2091,8 +2091,6 @@ gst_deinterlace_getcaps (GstPad * pad)
const GstCaps *ourcaps;
GstCaps *peercaps;
GST_OBJECT_LOCK (self);
otherpad = (pad == self->srcpad) ? self->sinkpad : self->srcpad;
ourcaps = gst_pad_get_pad_template_caps (pad);
@ -2106,8 +2104,6 @@ gst_deinterlace_getcaps (GstPad * pad)
ret = gst_caps_copy (ourcaps);
}
GST_OBJECT_UNLOCK (self);
for (len = gst_caps_get_size (ret); len > 0; len--) {
GstStructure *s = gst_caps_get_structure (ret, len - 1);