mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-05 23:18:52 +00:00
Code Issues 1 Projects Releases Wiki Activity

v4l2src: make this work more than once in a row

Browse source 
We used to skip frame rate setup if the camera was already setup
with the requested frame rate. This breaks some cameras though,
causing them to not output data (several models of Thinkpad cameras
have this problem at least).
So, don't skip.

https://bugzilla.gnome.org/show_bug.cgi?id=638300
This commit is contained in:
Vincent Penquerc'h 2011-08-25 23:37:47 +01:00 committed by Sebastian Dröge
parent f3fc3e1f69
commit 3968dc7688
1 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
sys/v4l2/v4l2src_calls.c
View file

@ -236,13 +236,11 @@ gst_v4l2src_set_capture (GstV4l2Src * v4l2src, guint32 pixelformat,
goto done; goto done;
} }
/* Note: V4L2 provides the frame interval, we have the frame rate */ /* We used to skip frame rate setup if the camera was already setup
if (gst_util_fraction_compare (stream.parm.capture.timeperframe.numerator, with the requested frame rate. This breaks some cameras though,
stream.parm.capture.timeperframe.denominator, fps_d, fps_n) == 0) { causing them to not output data (several models of Thinkpad cameras
have this problem at least).
GST_DEBUG_OBJECT (v4l2src, "Desired framerate already set"); So, don't skip. */
goto already_set;
}
/* We want to change the frame rate, so check whether we can. Some cheap USB /* We want to change the frame rate, so check whether we can. Some cheap USB
* cameras don't have the capability */ * cameras don't have the capability */
@ -265,8 +263,6 @@ gst_v4l2src_set_capture (GstV4l2Src * v4l2src, guint32 pixelformat,
goto done; goto done;
} }
already_set:
v4l2src->fps_n = fps_n; v4l2src->fps_n = fps_n;
v4l2src->fps_d = fps_d; v4l2src->fps_d = fps_d;