mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-27 09:38:17 +00:00
Code Issues 1 Projects Releases Wiki Activity

flacparse: Really post tags only after the initial newsegment event

Browse source 
The first newsegment event will be send by the first call to
gst_base_parse_push_buffer() if necessary, posting the tags
before that is not a good idea. Instead do it from the
GstBaseParse::pre_push_buffer vfunc.
This commit is contained in:
Sebastian Dröge 2010-10-06 18:32:51 +02:00
parent 59720fd42a
commit 396501784c
1 changed files with 18 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
gst/audioparsers/gstflacparse.c
View file

@ -198,6 +198,8 @@ static GstFlowReturn gst_flac_parse_parse_frame (GstBaseParse * parse,
GstBuffer * buffer); GstBuffer * buffer);
static gint gst_flac_parse_get_frame_overhead (GstBaseParse * parse, static gint gst_flac_parse_get_frame_overhead (GstBaseParse * parse,
GstBuffer * buffer); GstBuffer * buffer);
static GstFlowReturn gst_flac_parse_pre_push_buffer (GstBaseParse * parse,
GstBuffer * buf);
GST_BOILERPLATE (GstFlacParse, gst_flac_parse, GstBaseParse, GST_BOILERPLATE (GstFlacParse, gst_flac_parse, GstBaseParse,
GST_TYPE_BASE_PARSE); GST_TYPE_BASE_PARSE);
@ -244,6 +246,8 @@ gst_flac_parse_class_init (GstFlacParseClass * klass)
baseparse_class->parse_frame = GST_DEBUG_FUNCPTR (gst_flac_parse_parse_frame); baseparse_class->parse_frame = GST_DEBUG_FUNCPTR (gst_flac_parse_parse_frame);
baseparse_class->get_frame_overhead = baseparse_class->get_frame_overhead =
GST_DEBUG_FUNCPTR (gst_flac_parse_get_frame_overhead); GST_DEBUG_FUNCPTR (gst_flac_parse_get_frame_overhead);
baseparse_class->pre_push_buffer =
GST_DEBUG_FUNCPTR (gst_flac_parse_pre_push_buffer);
} }
static void static void
@ -1182,11 +1186,6 @@ push_headers:
gst_pad_set_caps (GST_BASE_PARSE_SRC_PAD (GST_BASE_PARSE (flacparse)), caps); gst_pad_set_caps (GST_BASE_PARSE_SRC_PAD (GST_BASE_PARSE (flacparse)), caps);
gst_caps_unref (caps); gst_caps_unref (caps);
/* Push tags */
if (flacparse->tags)
gst_element_found_tags (GST_ELEMENT (flacparse),
gst_tag_list_copy (flacparse->tags));
/* push header buffers; update caps, so when we push the first buffer the /* push header buffers; update caps, so when we push the first buffer the
* negotiated caps will change to caps that include the streamheader field */ * negotiated caps will change to caps that include the streamheader field */
for (l = flacparse->headers; l != NULL; l = l->next) { for (l = flacparse->headers; l != NULL; l = l->next) {
@ -1481,3 +1480,17 @@ gst_flac_parse_get_frame_overhead (GstBaseParse * parse, GstBuffer * buffer)
* the second even less, so the total inaccuracy is negligible. */ * the second even less, so the total inaccuracy is negligible. */
return 7; return 7;
} }
static GstFlowReturn
gst_flac_parse_pre_push_buffer (GstBaseParse * parse, GstBuffer * buf)
{
GstFlacParse *flacparse = GST_FLAC_PARSE (parse);
/* Push tags */
if (flacparse->tags) {
gst_element_found_tags (GST_ELEMENT (flacparse), flacparse->tags);
flacparse->tags = NULL;
}
return GST_FLOW_OK;
}