mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-03-28 11:55:39 +00:00
Code Issues 1 Projects Releases Wiki Activity

bin: fix leaks in unit tests

Browse source 
The test rely on bus being flushed when setting the bin to the NULL state which
is not the case. This apply only when setting the pipeline state to
NULL.

https://bugzilla.gnome.org/show_bug.cgi?id=765720
This commit is contained in:
Guillaume Desmottes 2016-04-28 14:59:51 +03:00 committed by Sebastian Dröge
parent 3146c12a67
commit 391f767098
1 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
tests/check/gst/gstbin.c
View file

@ -296,6 +296,8 @@ GST_START_TEST (test_message_state_changed)
ASSERT_OBJECT_REFCOUNT (bin, "bin", 1);
gst_bus_set_flushing (bus, TRUE);
/* clean up */
ret = gst_element_set_state (GST_ELEMENT (bin), GST_STATE_NULL);
fail_unless (ret == GST_STATE_CHANGE_SUCCESS);
@ -359,9 +361,12 @@ GST_START_TEST (test_message_state_changed_child)
ASSERT_OBJECT_REFCOUNT (src, "src", 1);
ASSERT_OBJECT_REFCOUNT (bin, "bin", 1);
gst_bus_set_flushing (bus, TRUE);
/* clean up */
ret = gst_element_set_state (GST_ELEMENT (bin), GST_STATE_NULL);
fail_unless (ret == GST_STATE_CHANGE_SUCCESS);
gst_object_unref (bus);
gst_object_unref (bin);
}
@ -579,7 +584,8 @@ GST_START_TEST (test_watch_for_state_change)
fail_unless (gst_bus_have_pending (bus) == FALSE,
"Unexpected messages on bus");
/* setting bin to NULL flushes the bus automatically */
gst_bus_set_flushing (bus, TRUE);
ret = gst_element_set_state (GST_ELEMENT (bin), GST_STATE_NULL);
fail_unless (ret == GST_STATE_CHANGE_SUCCESS);
@ -1422,6 +1428,7 @@ GST_START_TEST (test_duration_is_max)
GstFormat format = GST_FORMAT_BYTES;
gboolean res;
gint64 duration;
GstBus *bus;
GST_INFO ("preparing test");
@ -1466,6 +1473,10 @@ GST_START_TEST (test_duration_is_max)
ck_assert_int_eq (duration, 3000);
bus = gst_element_get_bus (bin);
gst_bus_set_flushing (bus, TRUE);
gst_object_unref (bus);
gst_element_set_state (bin, GST_STATE_NULL);
gst_object_unref (bin);
}
@ -1479,6 +1490,7 @@ GST_START_TEST (test_duration_unknown_overrides)
GstFormat format = GST_FORMAT_BYTES;
gboolean res;
gint64 duration;
GstBus *bus;
GST_INFO ("preparing test");
@ -1523,6 +1535,10 @@ GST_START_TEST (test_duration_unknown_overrides)
ck_assert_int_eq (duration, GST_CLOCK_TIME_NONE);
bus = gst_element_get_bus (bin);
gst_bus_set_flushing (bus, TRUE);
gst_object_unref (bus);
gst_element_set_state (bin, GST_STATE_NULL);
gst_object_unref (bin);
}