mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-27 20:21:24 +00:00
Code Issues 1 Projects Releases Wiki Activity

webrtcbin: Make sure PC_LOCK is release when replying to promise

Browse source 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2104>
This commit is contained in:
Olivier Crête 2021-04-01 14:41:11 -04:00
parent 913383166b
commit 38ef12063d
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
ext/webrtc/gstwebrtcbin.c
View file

@ -759,6 +759,8 @@ _execute_op (GstWebRTCBinTask * op)
{
PC_LOCK (op->webrtc);
if (op->webrtc->priv->is_closed) {
PC_UNLOCK (op->webrtc);
if (op->promise) {
GError *error =
g_error_new (GST_WEBRTC_BIN_ERROR, GST_WEBRTC_BIN_ERROR_CLOSED,
@ -778,8 +780,9 @@ _execute_op (GstWebRTCBinTask * op)
op->op (op->webrtc, op->data);
out:
PC_UNLOCK (op->webrtc);
out:
return G_SOURCE_REMOVE;
}
@ -5462,11 +5465,16 @@ _free_get_stats (struct get_stats *stats)
static void
_get_stats_task (GstWebRTCBin * webrtc, struct get_stats *stats)
{
GstStructure *s;
/* Our selector is the pad,
* https://www.w3.org/TR/webrtc/#dfn-stats-selection-algorithm
*/
gst_promise_reply (stats->promise, gst_webrtc_bin_create_stats (webrtc,
stats->pad));
s = gst_webrtc_bin_create_stats (webrtc, stats->pad);
PC_UNLOCK (webrtc);
gst_promise_reply (stats->promise, s);
PC_LOCK (webrtc);
}
static void