mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-27 20:21:24 +00:00
Code Issues 1 Projects Releases Wiki Activity

ext/alsa/gstalsamixer.c (source, n_poll_fds, poll_fds, gst_alsa_mixer_check, gst_alsa_mixer_dispatch, gst_alsa_mixer_...

Browse source 
Original commit message from CVS:
* ext/alsa/gstalsamixer.c (source, n_poll_fds, poll_fds,
gst_alsa_mixer_check, gst_alsa_mixer_dispatch,
gst_alsa_mixer_finalize, gst_alsa_mixer_handle_source_callback,
gst_alsa_mixer_handle_callback, gst_alsa_mixer_elem_handle_callback,
gst_alsa_mixer_ensure_track_list, gst_alsa_mixer_update_option,
gst_alsa_mixer_update_track):
Apply some of the cleanup Tim suggested in #152864 afterwards.
This commit is contained in:
Stefan Kost 2007-05-15 15:29:17 +00:00
parent f2df2a6948
commit 38da64193b
2 changed files with 23 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ChangeLog
View file

@ -1,3 +1,13 @@
2007-05-15 Stefan Kost <ensonic@users.sf.net>
* ext/alsa/gstalsamixer.c (source, n_poll_fds, poll_fds,
gst_alsa_mixer_check, gst_alsa_mixer_dispatch,
gst_alsa_mixer_finalize, gst_alsa_mixer_handle_source_callback,
gst_alsa_mixer_handle_callback, gst_alsa_mixer_elem_handle_callback,
gst_alsa_mixer_ensure_track_list, gst_alsa_mixer_update_option,
gst_alsa_mixer_update_track):
Apply some of the cleanup Tim suggested in #152864 afterwards.
2007-05-15 Stefan Kost <ensonic@users.sf.net> 2007-05-15 Stefan Kost <ensonic@users.sf.net>
patch by: Marc-Andre Lureau <marcandre.lureau@gmail.com> patch by: Marc-Andre Lureau <marcandre.lureau@gmail.com>

31
ext/alsa/gstalsamixer.c
View file

@ -91,7 +91,7 @@ gst_alsa_mixer_check (GSource * source)
} }
if (revents & G_IO_ERR || revents & G_IO_HUP) { if (revents & G_IO_ERR || revents & G_IO_HUP) {
GST_WARNING ("ALSA poll fds returned ERR or HUP"); GST_DEBUG ("ALSA poll fds returned ERR or HUP");
return FALSE; return FALSE;
} }
@ -102,10 +102,7 @@ static gboolean
gst_alsa_mixer_dispatch (GSource * source, GSourceFunc callback, gst_alsa_mixer_dispatch (GSource * source, GSourceFunc callback,
gpointer user_data) gpointer user_data)
{ {
if (!callback) { g_return_val_if_fail (callback, FALSE);
GST_WARNING ("Cannot get callback from ALSA mixer watcher");
}
return (*callback) (user_data); return (*callback) (user_data);
} }
@ -253,7 +250,7 @@ gst_alsa_mixer_handle_source_callback (gpointer data)
{ {
GstAlsaMixer *mixer = (GstAlsaMixer *) data; GstAlsaMixer *mixer = (GstAlsaMixer *) data;
GST_WARNING ("Source cb"); GST_LOG ("Source cb");
snd_mixer_handle_events (mixer->handle); snd_mixer_handle_events (mixer->handle);
return TRUE; return TRUE;
@ -267,7 +264,7 @@ gst_alsa_mixer_handle_callback (snd_mixer_t * handle, unsigned int mask,
(GstAlsaMixer *) snd_mixer_get_callback_private (handle); (GstAlsaMixer *) snd_mixer_get_callback_private (handle);
GList *item; GList *item;
GST_WARNING ("ALSA cb"); GST_LOG ("ALSA cb");
snd_mixer_handle_events (mixer->handle); snd_mixer_handle_events (mixer->handle);
for (item = mixer->tracklist; item != NULL; item = item->next) { for (item = mixer->tracklist; item != NULL; item = item->next) {
@ -292,7 +289,7 @@ gst_alsa_mixer_elem_handle_callback (snd_mixer_elem_t * elem, unsigned int mask)
(GstAlsaMixer *) snd_mixer_elem_get_callback_private (elem); (GstAlsaMixer *) snd_mixer_elem_get_callback_private (elem);
GList *item; GList *item;
GST_WARNING ("ALSA elem cb"); GST_LOG ("ALSA elem cb");
for (item = mixer->tracklist; item != NULL; item = item->next) { for (item = mixer->tracklist; item != NULL; item = item->next) {
if (GST_IS_ALSA_MIXER_TRACK (item->data)) { if (GST_IS_ALSA_MIXER_TRACK (item->data)) {
@ -415,7 +412,6 @@ gst_alsa_mixer_ensure_track_list (GstAlsaMixer * mixer)
} }
} }
if (play_track && cap_track) { if (play_track && cap_track) {
GST_ALSA_MIXER_TRACK (play_track)->shared_mute = GST_ALSA_MIXER_TRACK (play_track)->shared_mute =
GST_ALSA_MIXER_TRACK (cap_track); GST_ALSA_MIXER_TRACK (cap_track);
@ -444,21 +440,20 @@ gst_alsa_mixer_ensure_track_list (GstAlsaMixer * mixer)
g_source_new (&gst_alsa_mixer_watch_funcs, sizeof (GstAlsaMixerWatch)); g_source_new (&gst_alsa_mixer_watch_funcs, sizeof (GstAlsaMixerWatch));
g_return_if_fail (main_context != NULL && mixer->handle_source != NULL); g_return_if_fail (main_context != NULL && mixer->handle_source != NULL);
watch = (GstAlsaMixerWatch *) mixer->handle_source;
count = snd_mixer_poll_descriptors_count (mixer->handle); count = snd_mixer_poll_descriptors_count (mixer->handle);
if (count < 1) {
pfds = g_newa (struct pollfd, count); GST_WARNING ("Poll descriptors count < 0: %d", count);
watch->n_poll_fds = snd_mixer_poll_descriptors (mixer->handle, pfds, count);;
watch->poll_fds = g_new0 (GPollFD, count);
if (watch->poll_fds == NULL) {
GST_WARNING ("Cannot allocate poll descriptors");
g_source_destroy (mixer->handle_source); g_source_destroy (mixer->handle_source);
mixer->handle_source = NULL; mixer->handle_source = NULL;
return; return;
} }
pfds = g_newa (struct pollfd, count);
watch = (GstAlsaMixerWatch *) mixer->handle_source;
watch->n_poll_fds = snd_mixer_poll_descriptors (mixer->handle, pfds, count);;
watch->poll_fds = g_new0 (GPollFD, count);
for (i = 0; i < watch->n_poll_fds; ++i) { for (i = 0; i < watch->n_poll_fds; ++i) {
watch->poll_fds[i].fd = pfds[i].fd; watch->poll_fds[i].fd = pfds[i].fd;