mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-05 23:18:52 +00:00
Code Issues 1 Projects Releases Wiki Activity

buffer: fix memory corruption

Browse source
This commit is contained in:
Philippe Normand 2010-11-15 11:49:24 +01:00 committed by Wim Taymans
parent 45645a11a1
commit 376089db14
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
gst/gstbuffer.c
View file

@ -289,7 +289,7 @@ _gst_buffer_copy (GstBuffer * buffer)
static void static void
_gst_buffer_free (GstBuffer * buffer) _gst_buffer_free (GstBuffer * buffer)
{ {
GList *walk; GstBufferMetaItem *walk, *next;
g_return_if_fail (buffer != NULL); g_return_if_fail (buffer != NULL);
@ -304,8 +304,9 @@ _gst_buffer_free (GstBuffer * buffer)
if (buffer->parent) if (buffer->parent)
gst_buffer_unref (buffer->parent); gst_buffer_unref (buffer->parent);
/* free metadata */ /* free metadata */
for (walk = buffer->priv; walk; walk = walk->next) { for (walk = buffer->priv; walk; walk = next) {
GstBufferMeta *meta = &walk->meta; GstBufferMeta *meta = &walk->meta;
const GstBufferMetaInfo *info = meta->info; const GstBufferMetaInfo *info = meta->info;
@ -313,7 +314,8 @@ _gst_buffer_free (GstBuffer * buffer)
if (info->free_func) if (info->free_func)
info->free_func (meta, buffer); info->free_func (meta, buffer);
/* and free the slice */ /* and free the slice */
g_slice_free1 (ITEM_SIZE (info), meta); next = walk->next;
g_slice_free (GstBufferMetaItem, walk);
} }
g_slice_free1 (GST_MINI_OBJECT_SIZE (buffer), buffer); g_slice_free1 (GST_MINI_OBJECT_SIZE (buffer), buffer);