mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-10 17:35:59 +00:00
Code Issues 1 Projects Releases Wiki Activity

ext/speex/gstspeexenc.c: Fix some mem leaks.

Browse source 
Original commit message from CVS:
* ext/speex/gstspeexenc.c: (gst_speexenc_finalize),
(gst_speexenc_set_last_msg), (gst_speexenc_setup),
(gst_speexenc_set_header_on_caps):
Fix some mem leaks.
This commit is contained in:
Tim-Philipp Müller 2006-10-12 18:35:10 +00:00
parent 7accf76da8
commit 35f4d69dec
2 changed files with 39 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
ChangeLog
View file

@ -1,3 +1,10 @@
2006-10-12 Tim-Philipp Müller <tim at centricular dot net>
* ext/speex/gstspeexenc.c: (gst_speexenc_finalize),
(gst_speexenc_set_last_msg), (gst_speexenc_setup),
(gst_speexenc_set_header_on_caps):
Fix some mem leaks.
2006-10-11 Wim Taymans <wim@fluendo.com> 2006-10-11 Wim Taymans <wim@fluendo.com>
* gst/rtsp/URLS: * gst/rtsp/URLS:

59
ext/speex/gstspeexenc.c
View file

@ -1,4 +1,4 @@
/* GStreamer /* GStreamer Speex Encoder
* Copyright (C) <1999> Erik Walthinsen <omega@cse.ogi.edu> * Copyright (C) <1999> Erik Walthinsen <omega@cse.ogi.edu>
* *
* This library is free software; you can redistribute it and/or * This library is free software; you can redistribute it and/or
@ -224,6 +224,7 @@ gst_speexenc_finalize (GObject * object)
speexenc = GST_SPEEXENC (object); speexenc = GST_SPEEXENC (object);
g_free (speexenc->last_message);
g_object_unref (speexenc->adapter); g_object_unref (speexenc->adapter);
G_OBJECT_CLASS (parent_class)->finalize (object); G_OBJECT_CLASS (parent_class)->finalize (object);
@ -543,6 +544,15 @@ gst_speexenc_create_metadata_buffer (GstSpeexEnc * enc)
return comments; return comments;
} }
static void
gst_speexenc_set_last_msg (GstSpeexEnc * enc, const gchar * msg)
{
g_free (enc->last_message);
enc->last_message = g_strdup (msg);
GST_WARNING_OBJECT (enc, "%s", msg);
g_object_notify (G_OBJECT (enc), "last-message");
}
static gboolean static gboolean
gst_speexenc_setup (GstSpeexEnc * speexenc) gst_speexenc_setup (GstSpeexEnc * speexenc)
{ {
@ -569,10 +579,8 @@ gst_speexenc_setup (GstSpeexEnc * speexenc)
speexenc->speex_mode = (SpeexMode *) & speex_uwb_mode; speexenc->speex_mode = (SpeexMode *) & speex_uwb_mode;
} else { } else {
if (speexenc->speex_mode != &speex_uwb_mode) { if (speexenc->speex_mode != &speex_uwb_mode) {
speexenc->last_message = gst_speexenc_set_last_msg (speexenc,
g_strdup_printf "Warning: suggest to use ultra wide band mode for this rate");
("Warning: suggest to use ultra wide band mode for this rate");
g_object_notify (G_OBJECT (speexenc), "last_message");
} }
} }
} else if (speexenc->rate > 12500) { } else if (speexenc->rate > 12500) {
@ -580,10 +588,8 @@ gst_speexenc_setup (GstSpeexEnc * speexenc)
speexenc->speex_mode = (SpeexMode *) & speex_wb_mode; speexenc->speex_mode = (SpeexMode *) & speex_wb_mode;
} else { } else {
if (speexenc->speex_mode != &speex_wb_mode) { if (speexenc->speex_mode != &speex_wb_mode) {
speexenc->last_message = gst_speexenc_set_last_msg (speexenc,
g_strdup_printf "Warning: suggest to use wide band mode for this rate");
("Warning: suggest to use wide band mode for this rate");
g_object_notify (G_OBJECT (speexenc), "last_message");
} }
} }
} else { } else {
@ -591,19 +597,16 @@ gst_speexenc_setup (GstSpeexEnc * speexenc)
speexenc->speex_mode = (SpeexMode *) & speex_nb_mode; speexenc->speex_mode = (SpeexMode *) & speex_nb_mode;
} else { } else {
if (speexenc->speex_mode != &speex_nb_mode) { if (speexenc->speex_mode != &speex_nb_mode) {
speexenc->last_message = gst_speexenc_set_last_msg (speexenc,
g_strdup_printf "Warning: suggest to use narrow band mode for this rate");
("Warning: suggest to use narrow band mode for this rate");
g_object_notify (G_OBJECT (speexenc), "last_message");
} }
} }
} }
if (speexenc->rate != 8000 && speexenc->rate != 16000 if (speexenc->rate != 8000 && speexenc->rate != 16000
&& speexenc->rate != 32000) { && speexenc->rate != 32000) {
speexenc->last_message = gst_speexenc_set_last_msg (speexenc,
g_strdup_printf ("Warning: speex is optimized for 8, 16 and 32 KHz"); "Warning: speex is optimized for 8, 16 and 32 KHz");
g_object_notify (G_OBJECT (speexenc), "last_message");
} }
speex_init_header (&speexenc->header, speexenc->rate, 1, speex_init_header (&speexenc->header, speexenc->rate, 1,
@ -631,9 +634,8 @@ gst_speexenc_setup (GstSpeexEnc * speexenc)
} }
if (speexenc->bitrate) { if (speexenc->bitrate) {
if (speexenc->quality >= 0.0 && speexenc->vbr) { if (speexenc->quality >= 0.0 && speexenc->vbr) {
speexenc->last_message = gst_speexenc_set_last_msg (speexenc,
g_strdup_printf ("Warning: bitrate option is overriding quality"); "Warning: bitrate option is overriding quality");
g_object_notify (G_OBJECT (speexenc), "last_message");
} }
speex_encoder_ctl (speexenc->state, SPEEX_SET_BITRATE, &speexenc->bitrate); speex_encoder_ctl (speexenc->state, SPEEX_SET_BITRATE, &speexenc->bitrate);
} }
@ -654,13 +656,11 @@ gst_speexenc_setup (GstSpeexEnc * speexenc)
} }
if (speexenc->dtx && !(speexenc->vbr || speexenc->abr || speexenc->vad)) { if (speexenc->dtx && !(speexenc->vbr || speexenc->abr || speexenc->vad)) {
speexenc->last_message = gst_speexenc_set_last_msg (speexenc,
g_strdup_printf ("Warning: dtx is useless without vad, vbr or abr"); "Warning: dtx is useless without vad, vbr or abr");
g_object_notify (G_OBJECT (speexenc), "last_message");
} else if ((speexenc->vbr || speexenc->abr) && (speexenc->vad)) { } else if ((speexenc->vbr || speexenc->abr) && (speexenc->vad)) {
speexenc->last_message = gst_speexenc_set_last_msg (speexenc,
g_strdup_printf ("Warning: vad is already implied by vbr or abr"); "Warning: vad is already implied by vbr or abr");
g_object_notify (G_OBJECT (speexenc), "last_message");
} }
if (speexenc->abr) { if (speexenc->abr) {
@ -707,6 +707,7 @@ gst_speexenc_set_header_on_caps (GstCaps * caps, GstBuffer * buf1,
GstBuffer * buf2) GstBuffer * buf2)
{ {
GstStructure *structure = NULL; GstStructure *structure = NULL;
GstBuffer *buf;
GValue array = { 0 }; GValue array = { 0 };
GValue value = { 0 }; GValue value = { 0 };
@ -723,11 +724,15 @@ gst_speexenc_set_header_on_caps (GstCaps * caps, GstBuffer * buf1,
/* put buffers in a fixed list */ /* put buffers in a fixed list */
g_value_init (&array, GST_TYPE_ARRAY); g_value_init (&array, GST_TYPE_ARRAY);
g_value_init (&value, GST_TYPE_BUFFER); g_value_init (&value, GST_TYPE_BUFFER);
gst_value_set_buffer (&value, buf1); buf = gst_buffer_copy (buf1);
gst_value_set_buffer (&value, buf);
gst_buffer_unref (buf);
gst_value_array_append_value (&array, &value); gst_value_array_append_value (&array, &value);
g_value_unset (&value); g_value_unset (&value);
g_value_init (&value, GST_TYPE_BUFFER); g_value_init (&value, GST_TYPE_BUFFER);
gst_value_set_buffer (&value, buf2); buf = gst_buffer_copy (buf2);
gst_value_set_buffer (&value, buf);
gst_buffer_unref (buf);
gst_value_array_append_value (&array, &value); gst_value_array_append_value (&array, &value);
gst_structure_set_value (structure, "streamheader", &array); gst_structure_set_value (structure, "streamheader", &array);
g_value_unset (&value); g_value_unset (&value);