mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-04 05:22:30 +00:00
Code Issues 1 Projects Releases Wiki Activity

bus: warn when message queue grows too much

Browse source 
It usually means application is not handling messages causing memory
consumption to grow infinitely.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3313>
This commit is contained in:
Xavier Claessens 2024-02-15 09:18:20 -05:00 committed by GStreamer Marge Bot
parent 88412ef100
commit 350345150e
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
subprojects/gstreamer/gst/gstbus.c
View file

@ -97,6 +97,7 @@ enum
}; };
#define DEFAULT_ENABLE_ASYNC (TRUE) #define DEFAULT_ENABLE_ASYNC (TRUE)
#define WARN_QUEUE_SIZE 1024
enum enum
{ {
@ -376,7 +377,14 @@ gst_bus_post (GstBus * bus, GstMessage * message)
/* drop the message */ /* drop the message */
GST_DEBUG_OBJECT (bus, "[msg %p] dropped", message); GST_DEBUG_OBJECT (bus, "[msg %p] dropped", message);
break; break;
case GST_BUS_PASS: case GST_BUS_PASS:{
guint length = gst_atomic_queue_length (bus->priv->queue);
if (G_UNLIKELY (length > 0 && length % WARN_QUEUE_SIZE == 0)) {
GST_WARNING_OBJECT (bus, "queue overflows with %d messages. "
"Application is too slow or is not handling messages. "
"Please add a message handler, otherwise the queue will grow "
"infinitely.", length);
}
/* pass the message to the async queue, refcount passed in the queue */ /* pass the message to the async queue, refcount passed in the queue */
GST_DEBUG_OBJECT (bus, "[msg %p] pushing on async queue", message); GST_DEBUG_OBJECT (bus, "[msg %p] pushing on async queue", message);
gst_atomic_queue_push (bus->priv->queue, message); gst_atomic_queue_push (bus->priv->queue, message);
@ -384,6 +392,7 @@ gst_bus_post (GstBus * bus, GstMessage * message)
GST_DEBUG_OBJECT (bus, "[msg %p] pushed on async queue", message); GST_DEBUG_OBJECT (bus, "[msg %p] pushed on async queue", message);
break; break;
}
case GST_BUS_ASYNC: case GST_BUS_ASYNC:
{ {
/* async delivery, we need a mutex and a cond to block /* async delivery, we need a mutex and a cond to block