mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-24 01:00:37 +00:00
Code Issues 1 Projects Releases Wiki Activity

ffdec: avoid generating caps when registering

Browse source 
Don't generate caps when we register the class but delay that till when
we actually create an instance of the class.
This commit is contained in:
Wim Taymans 2009-10-22 16:27:28 -04:00 committed by Wim Taymans
parent 629969b695
commit 343c82b18c
1 changed files with 24 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

55
ext/ffmpeg/gstffmpegdec.c
View file

@ -174,7 +174,6 @@ typedef struct _GstFFMpegDecClassParams GstFFMpegDecClassParams;
struct _GstFFMpegDecClassParams struct _GstFFMpegDecClassParams
{ {
AVCodec *in_plugin; AVCodec *in_plugin;
GstCaps *srccaps, *sinkcaps;
}; };
#define GST_TYPE_FFMPEGDEC \ #define GST_TYPE_FFMPEGDEC \
@ -300,12 +299,16 @@ gst_ffmpegdec_base_init (GstFFMpegDecClass * klass)
GstFFMpegDecClassParams *params; GstFFMpegDecClassParams *params;
GstElementDetails details; GstElementDetails details;
GstPadTemplate *sinktempl, *srctempl; GstPadTemplate *sinktempl, *srctempl;
GstCaps *sinkcaps, *srccaps;
AVCodec *in_plugin;
params = params =
(GstFFMpegDecClassParams *) g_type_get_qdata (G_OBJECT_CLASS_TYPE (klass), (GstFFMpegDecClassParams *) g_type_get_qdata (G_OBJECT_CLASS_TYPE (klass),
GST_FFDEC_PARAMS_QDATA); GST_FFDEC_PARAMS_QDATA);
g_assert (params != NULL); g_assert (params != NULL);
in_plugin = params->in_plugin;
/* construct the element details struct */ /* construct the element details struct */
details.longname = g_strdup_printf ("FFmpeg %s decoder", details.longname = g_strdup_printf ("FFmpeg %s decoder",
params->in_plugin->long_name); params->in_plugin->long_name);
@ -321,16 +324,32 @@ gst_ffmpegdec_base_init (GstFFMpegDecClass * klass)
g_free (details.klass); g_free (details.klass);
g_free (details.description); g_free (details.description);
/* get the caps */
sinkcaps = gst_ffmpeg_codecid_to_caps (in_plugin->id, NULL, FALSE);
if (!sinkcaps) {
GST_DEBUG ("Couldn't get sink caps for decoder '%s'", in_plugin->name);
sinkcaps = gst_caps_from_string ("unknown/unknown");
}
if (in_plugin->type == CODEC_TYPE_VIDEO) {
srccaps = gst_caps_from_string ("video/x-raw-rgb; video/x-raw-yuv");
} else {
srccaps = gst_ffmpeg_codectype_to_audio_caps (NULL,
in_plugin->id, FALSE, in_plugin);
}
if (!srccaps) {
GST_DEBUG ("Couldn't get source caps for decoder '%s'", in_plugin->name);
srccaps = gst_caps_from_string ("unknown/unknown");
}
/* pad templates */ /* pad templates */
sinktempl = gst_pad_template_new ("sink", GST_PAD_SINK, sinktempl = gst_pad_template_new ("sink", GST_PAD_SINK,
GST_PAD_ALWAYS, params->sinkcaps); GST_PAD_ALWAYS, sinkcaps);
srctempl = gst_pad_template_new ("src", GST_PAD_SRC, srctempl = gst_pad_template_new ("src", GST_PAD_SRC, GST_PAD_ALWAYS, srccaps);
GST_PAD_ALWAYS, params->srccaps);
gst_element_class_add_pad_template (element_class, srctempl); gst_element_class_add_pad_template (element_class, srctempl);
gst_element_class_add_pad_template (element_class, sinktempl); gst_element_class_add_pad_template (element_class, sinktempl);
klass->in_plugin = params->in_plugin; klass->in_plugin = in_plugin;
klass->srctempl = srctempl; klass->srctempl = srctempl;
klass->sinktempl = sinktempl; klass->sinktempl = sinktempl;
} }
@ -2761,7 +2780,6 @@ gst_ffmpegdec_register (GstPlugin * plugin)
while (in_plugin) { while (in_plugin) {
GstFFMpegDecClassParams *params; GstFFMpegDecClassParams *params;
GstCaps *srccaps = NULL, *sinkcaps = NULL;
gchar *type_name; gchar *type_name;
gchar *plugin_name; gchar *plugin_name;
@ -2822,25 +2840,6 @@ gst_ffmpegdec_register (GstPlugin * plugin)
goto next; goto next;
} }
/* first make sure we've got a supported type */
sinkcaps = gst_ffmpeg_codecid_to_caps (in_plugin->id, NULL, FALSE);
if (!sinkcaps) {
GST_DEBUG ("Couldn't get sink caps for decoder '%s', skipping codec",
in_plugin->name);
goto next;
}
if (in_plugin->type == CODEC_TYPE_VIDEO) {
srccaps = gst_caps_from_string ("video/x-raw-rgb; video/x-raw-yuv");
} else {
srccaps = gst_ffmpeg_codectype_to_audio_caps (NULL,
in_plugin->id, FALSE, in_plugin);
}
if (!srccaps) {
GST_DEBUG ("Couldn't get source caps for decoder '%s', skipping codec",
in_plugin->name);
goto next;
}
/* construct the type */ /* construct the type */
plugin_name = g_strdup ((gchar *) in_plugin->name); plugin_name = g_strdup ((gchar *) in_plugin->name);
g_strdelimit (plugin_name, NULL, '_'); g_strdelimit (plugin_name, NULL, '_');
@ -2852,8 +2851,6 @@ gst_ffmpegdec_register (GstPlugin * plugin)
if (!type) { if (!type) {
params = g_new0 (GstFFMpegDecClassParams, 1); params = g_new0 (GstFFMpegDecClassParams, 1);
params->in_plugin = in_plugin; params->in_plugin = in_plugin;
params->srccaps = gst_caps_ref (srccaps);
params->sinkcaps = gst_caps_ref (sinkcaps);
/* create the gtype now */ /* create the gtype now */
type = g_type_register_static (GST_TYPE_ELEMENT, type_name, &typeinfo, 0); type = g_type_register_static (GST_TYPE_ELEMENT, type_name, &typeinfo, 0);
@ -2902,10 +2899,6 @@ gst_ffmpegdec_register (GstPlugin * plugin)
g_free (type_name); g_free (type_name);
next: next:
if (sinkcaps)
gst_caps_unref (sinkcaps);
if (srccaps)
gst_caps_unref (srccaps);
in_plugin = av_codec_next (in_plugin); in_plugin = av_codec_next (in_plugin);
} }