mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-29 19:50:40 +00:00
Code Issues 1 Projects Releases Wiki Activity

capsfilter: don't assume _get_caps still has to be

Browse source 
_set_caps only gets called when the buffer is actually pushed, so there
is a reasonably big window between when the initial caps are retrieved
and when the caps are set on our src pad. So we can't assume the not
having negotiated caps on our src pad means _get_caps still has to be
called.

Instead simply always suggest the new caps on buffer_alloc.
This commit is contained in:
Sjoerd Simons 2011-07-20 14:05:27 +02:00 committed by Sebastian Dröge
parent c1988b7e55
commit 341d7a4c0d
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
plugins/elements/gstcapsfilter.c
View file

@ -204,9 +204,10 @@ gst_capsfilter_set_property (GObject * object, guint prop_id,
}
} else {
GST_DEBUG_OBJECT (capsfilter, "no negotiated caps");
/* no previous caps, the getcaps function will be used to find suitable
* caps */
suggest = NULL;
/* Suggest the new caps, we can't just rely on _get_caps as this may
* already be called at this point even though no buffer has been
* pushed yet */
suggest = gst_caps_copy (new_caps);
}
GST_OBJECT_UNLOCK (GST_BASE_TRANSFORM_SINK_PAD (object));