mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-20 15:27:07 +00:00
Code Issues 1 Projects Releases Wiki Activity

typefindhelper: fix confusing debug log message

Browse source 
In case of a short buffer, the debug log is quite confusing.
Distinguish the two types of failure cases to make it clearer.

https://bugzilla.gnome.org/show_bug.cgi?id=792486
This commit is contained in:
Jun Xie 2018-01-13 11:08:00 +08:00 committed by Tim-Philipp Müller
parent 968dd651c2
commit 33e7269c37
1 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
libs/gst/base/gsttypefindhelper.c
View file

@ -167,10 +167,16 @@ helper_find_peek (gpointer data, gint64 offset, guint size)
buf_offset = GST_BUFFER_OFFSET (buffer); buf_offset = GST_BUFFER_OFFSET (buffer);
buf_size = gst_buffer_get_size (buffer); buf_size = gst_buffer_get_size (buffer);
if ((buf_offset != -1 && buf_offset != offset) || buf_size < size) { if (buf_size < size) {
GST_DEBUG ("dropping short buffer: %" G_GUINT64_FORMAT "-%" G_GUINT64_FORMAT GST_DEBUG ("dropping short buffer of size %" G_GSIZE_FORMAT ","
" instead of %" G_GUINT64_FORMAT "-%" G_GUINT64_FORMAT, "requested size was %u", buf_size, size);
buf_offset, buf_offset + buf_size - 1, offset, offset + size - 1); gst_buffer_unref (buffer);
return NULL;
}
if (buf_offset != -1 && buf_offset != offset) {
GST_DEBUG ("dropping buffer with unexpected offset %" G_GUINT64_FORMAT ", "
"expected offset was %" G_GUINT64_FORMAT, buf_offset, offset);
gst_buffer_unref (buffer); gst_buffer_unref (buffer);
return NULL; return NULL;
} }