mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-03 01:02:19 +00:00
Code Issues 1 Projects Releases Wiki Activity

input-selector: Forward segment events for the active pad immediately.

Browse source 
When a segment event is received on the active pad, forward it downstream
immediately instead of deferring it until the next data buffer arrives. This
fixes problems with segment updates never being sent downstream, like those
needed for sparse streams, or for closing previously opened segments.

This fixes playback of DVD menus with a still video frame and an audio track,
for example.

Fixes: #577843
This commit is contained in:
Jan Schmidt 2009-04-23 11:04:46 +01:00 committed by Tim-Philipp Müller
parent 5a63373aa5
commit 33ad3b9fad
1 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
plugins/elements/gstinputselector.c
View file

@ -392,12 +392,17 @@ gst_selector_pad_event (GstPad * pad, GstEvent * event)
gst_segment_set_newsegment_full (&selpad->segment, update,
rate, arate, format, start, stop, time);
GST_OBJECT_UNLOCK (selpad);
/* we are not going to forward the segment, mark the segment as
* pending */
forward = FALSE;
selpad->segment_pending = TRUE;
GST_INPUT_SELECTOR_UNLOCK (sel);
/* If we aren't forwarding the event (because the pad is not the
* active_sinkpad, and select_all is not set, then set the flag on the
* that says a segment needs sending if/when that pad is activated.
* For all other cases, we send the event immediately, which makes
* sparse streams and other segment updates work correctly downstream.
*/
if (!forward)
selpad->segment_pending = TRUE;
GST_INPUT_SELECTOR_UNLOCK (sel);
break;
}
case GST_EVENT_TAG: