mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-04 09:42:19 +00:00
Code Issues 1 Projects Releases Wiki Activity

timedvaluecontrolsource: Check that the only iter is the end iter in the GSequence

Browse source 
Previous patch was assuming that if the returned iter was the last iter
the GSequence was empty, which is obviously wrong.
This commit is contained in:
Thibault Saunier 2015-05-16 12:57:12 +02:00
parent 78bbaeb6e7
commit 33924a7f04
1 changed files with 14 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
libs/gst/controller/gsttimedvaluecontrolsource.c
View file

@ -182,21 +182,24 @@ gst_timed_value_control_source_set_internal (GstTimedValueControlSource *
iter =
g_sequence_search (self->values, &timestamp,
(GCompareDataFunc) gst_control_point_find, NULL);
if (iter && !g_sequence_iter_is_end (iter)) {
if (iter) {
GSequenceIter *prev = g_sequence_iter_prev (iter);
GstControlPoint *cp = g_sequence_get (prev);
/* If the timestamp is the same just update the control point value */
if (cp->timestamp == timestamp) {
if (!g_sequence_iter_is_end (prev)) {
GstControlPoint *cp = g_sequence_get (prev);
/* update control point */
cp->value = value;
g_mutex_unlock (&self->lock);
/* If the timestamp is the same just update the control point value */
if (cp->timestamp == timestamp) {
g_signal_emit (self,
gst_timed_value_control_source_signals[VALUE_CHANGED_SIGNAL], 0,
cp);
goto done;
/* update control point */
cp->value = value;
g_mutex_unlock (&self->lock);
g_signal_emit (self,
gst_timed_value_control_source_signals[VALUE_CHANGED_SIGNAL], 0,
cp);
goto done;
}
}
}
} else {