mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-05 10:12:20 +00:00
Code Issues 1 Projects Releases Wiki Activity

gst/qtmux/gstqtmux.c: Add some more safety/sanity checks in tag manipulation.

Browse source 
Original commit message from CVS:
* gst/qtmux/gstqtmux.c: (gst_qt_mux_add_metadata_tags):
Add some more safety/sanity checks in tag manipulation.
This commit is contained in:
Mark Nauwelaerts 2008-11-11 19:24:12 +00:00
parent a1d2af2cdb
commit 335402cd75
2 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ChangeLog
View file

@ -1,3 +1,8 @@
2008-11-11 Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
* gst/qtmux/gstqtmux.c: (gst_qt_mux_add_metadata_tags):
Add some more safety/sanity checks in tag manipulation.
2008-11-10 Wim Taymans <wim.taymans@collabora.co.uk> 2008-11-10 Wim Taymans <wim.taymans@collabora.co.uk>
* gst/rtpmanager/gstrtpjitterbuffer.c: * gst/rtpmanager/gstrtpjitterbuffer.c:

8
gst/qtmux/gstqtmux.c
View file

@ -360,9 +360,9 @@ gst_qt_mux_add_metadata_tags (GstQTMux * qtmux, const GstTagList * list)
/* strings */ /* strings */
case G_TYPE_STRING: case G_TYPE_STRING:
{ {
gchar *str; gchar *str = NULL;
if (!gst_tag_list_get_string (list, tag, &str)) if (!gst_tag_list_get_string (list, tag, &str) || !str)
break; break;
GST_DEBUG_OBJECT (qtmux, "Adding tag %" GST_FOURCC_FORMAT " -> %s", GST_DEBUG_OBJECT (qtmux, "Adding tag %" GST_FOURCC_FORMAT " -> %s",
GST_FOURCC_ARGS (fourcc), str); GST_FOURCC_ARGS (fourcc), str);
@ -400,13 +400,13 @@ gst_qt_mux_add_metadata_tags (GstQTMux * qtmux, const GstTagList * list)
default: default:
{ {
if (gst_tag_get_type (tag) == GST_TYPE_DATE) { if (gst_tag_get_type (tag) == GST_TYPE_DATE) {
GDate *date; GDate *date = NULL;
GDateYear year; GDateYear year;
GDateMonth month; GDateMonth month;
GDateDay day; GDateDay day;
gchar *str; gchar *str;
if (!gst_tag_list_get_date (list, tag, &date)) if (!gst_tag_list_get_date (list, tag, &date) || !date)
break; break;
year = g_date_get_year (date); year = g_date_get_year (date);
month = g_date_get_month (date); month = g_date_get_month (date);