mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-24 09:10:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

rtpbasedepayload: remove object locking an extension

Browse source 
Doing that is fraught with danger of deadlocks and is not conceptually
part of the API contract.  The object lock is generally intended for
internal-object-use only.

If another lock is needed, that should be added separately.

This lock was erronously added as part of:
https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1118

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1233>
This commit is contained in:
Matthew Waters 2021-07-27 17:44:02 +10:00 committed by GStreamer Marge Bot
parent 17cb683615
commit 32170aa6c2
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
gst-libs/gst/rtp/gstrtpbasedepayload.c
View file

@ -1233,12 +1233,10 @@ read_rtp_header_extensions (GstRTPBaseDepayload * depayload,
}
if (ext) {
GST_OBJECT_LOCK (ext);
if (!gst_rtp_header_extension_read (ext, ext_flags, &pdata[offset],
read_len, output)) {
GST_WARNING_OBJECT (depayload, "RTP header extension (%s) could "
"not read payloaded data", GST_OBJECT_NAME (ext));
GST_OBJECT_UNLOCK (ext);
gst_object_unref (ext);
goto out;
}
@ -1247,7 +1245,6 @@ read_rtp_header_extensions (GstRTPBaseDepayload * depayload,
needs_src_caps_update = TRUE;
}
GST_OBJECT_UNLOCK (ext);
gst_object_unref (ext);
}
GST_OBJECT_UNLOCK (depayload);