mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-22 23:28:16 +00:00
Code Issues 1 Projects Releases Wiki Activity

audioencoder: Fix gst_audio_encoder_get_audio_info return ownership GTK-Doc

Browse source 
GTK-Doc specifies that, by default, the caller owns returned objects, so that the caller should free them when it is done. However, in the case of this function, the returned GstAudioInfo is owned by the decoder, so this default choice is incorrect. This creates double free problems when using GStreamer Rust bindings, because they are generated using the information contained in the docs.

Fix this by correctly specifying that the caller does not own the returned object.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1032>
This commit is contained in:
Alejandro González 2021-02-13 21:25:18 +00:00
parent 2fd2540ea5
commit 319da90d4c
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gst-libs/gst/audio/gstaudioencoder.c
View file

@ -2150,7 +2150,7 @@ gst_audio_encoder_sink_activate_mode (GstPad * pad, GstObject * parent,
* gst_audio_encoder_get_audio_info: * gst_audio_encoder_get_audio_info:
* @enc: a #GstAudioEncoder * @enc: a #GstAudioEncoder
* *
* Returns: a #GstAudioInfo describing the input audio format * Returns: (transfer none): a #GstAudioInfo describing the input audio format
*/ */
GstAudioInfo * GstAudioInfo *
gst_audio_encoder_get_audio_info (GstAudioEncoder * enc) gst_audio_encoder_get_audio_info (GstAudioEncoder * enc)