mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-19 08:11:16 +00:00
Code Issues 1 Projects Releases Wiki Activity

utils: fix element leak in find_common_root()

Browse source 
The root element was not unreffed when iterating over ancestors.

https://bugzilla.gnome.org/show_bug.cgi?id=765961
This commit is contained in:
Guillaume Desmottes 2016-05-04 09:53:32 +02:00 committed by Sebastian Dröge
parent 4fe32b923f
commit 30ee36e630
2 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gst/gstutils.c
View file

@ -1363,11 +1363,13 @@ find_common_root (GstObject * o1, GstObject * o2)
gst_object_unref (kid2);
return root;
}
gst_object_unref (root);
root = kid2;
if (!object_has_ancestor (o2, kid1, &kid2)) {
gst_object_unref (kid1);
return root;
}
gst_object_unref (root);
root = kid1;
}
}

1
tests/check/pipelines/parse-launch.c
View file

@ -52,6 +52,7 @@ setup_pipeline (const gchar * pipe_descr)
fail_unless (pipeline != NULL, "Failed to create pipeline %s", pipe_descr);
/* Newly returned object should be floating reffed */
fail_unless (g_object_is_floating (pipeline));
g_assert_cmpuint (G_OBJECT (pipeline)->ref_count, ==, 1);
return pipeline;
}