mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 06:54:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

basetransform: Don't push out identical caps

Browse source 
This avoids triggering plenty of extra code/methods/overhead downstream when
we can just quickly check whenever we want to set caps whether they are
identical or not

https://bugzilla.gnome.org/show_bug.cgi?id=706600
This commit is contained in:
Edward Hervey 2013-08-22 19:01:32 +02:00
parent aa1890a4b4
commit 307d67f8c0
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
libs/gst/base/gstbasetransform.c
View file

@ -1298,7 +1298,7 @@ gst_base_transform_setcaps (GstBaseTransform * trans, GstPad * pad,
GstCaps * incaps) GstCaps * incaps)
{ {
GstBaseTransformPrivate *priv = trans->priv; GstBaseTransformPrivate *priv = trans->priv;
GstCaps *outcaps; GstCaps *outcaps, *prevcaps;
gboolean ret = TRUE; gboolean ret = TRUE;
GST_DEBUG_OBJECT (pad, "have new caps %p %" GST_PTR_FORMAT, incaps, incaps); GST_DEBUG_OBJECT (pad, "have new caps %p %" GST_PTR_FORMAT, incaps, incaps);
@ -1321,8 +1321,14 @@ gst_base_transform_setcaps (GstBaseTransform * trans, GstPad * pad,
if (!(ret = gst_base_transform_configure_caps (trans, incaps, outcaps))) if (!(ret = gst_base_transform_configure_caps (trans, incaps, outcaps)))
goto failed_configure; goto failed_configure;
/* let downstream know about our caps */ prevcaps = gst_pad_get_current_caps (trans->srcpad);
ret = gst_pad_set_caps (trans->srcpad, outcaps);
if (!prevcaps || !gst_caps_is_equal (outcaps, prevcaps))
/* let downstream know about our caps */
ret = gst_pad_set_caps (trans->srcpad, outcaps);
if (prevcaps)
gst_caps_unref (prevcaps);
if (ret) { if (ret) {
/* try to get a pool when needed */ /* try to get a pool when needed */